LibWeb/CSS: Populate 'cached_x_samples' properly in 'CubicBezier::evaluate_at' #3676
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the |
When we populate 'm_cached_x_samples' the last value might be less than 1.0, which leads to a crash when 'input_progress == 1' since the binary search populate 'nearby_index' with the index of the last element in 'm_cached_x_samples' and when we try to linearly interpolate between 'm_cached_x_samples[nearby_index]' and m_cached_x_samples[nearby_index + 2] we crash because of an index out of bounds assertion failure. This change makes sure the loop responsible for populating 'm_cached_x_samples' reaches 'input_progress'.
mobounya
force-pushed
the
fix-cubic-bezier-evaluate-at
branch
from
32f3821 to
93468cc
Compare
|
Hi! Could you add a test exposing the issue you've fixed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we populate 'm_cached_x_samples' the last value might be less than 1.0, which leads to a crash when 'input_progress == 1' since the binary search populate 'nearby_index' with the index of the last element in 'm_cached_x_samples' and when we try to linearly interpolate between 'm_cached_x_samples[nearby_index]' and m_cached_x_samples[nearby_index + 2] we crash because of an index out of bounds assertion failure.
This change makes sure the loop responsible for populating 'm_cached_x_samples' reaches 'input_progress'.
This fixes the issue described in #3628