docs: Try removing an unnecessarily complicated case

Summary: I looked at all the cases where a `DocFunction` was constructed (`NativeCallable`, `Def`, and `RuleCallable`) and those starlark values already return a `typechecker_ty`, so this should be dead code

Reviewed By: stepancheg

Differential Revision: D60917925

fbshipit-source-id: 7d2940b9c8dae41e3e2491e55b4b4f0cbbf844a4

starlark-rust/starlark/src/typing/ty.rs

@@ -29,8 +29,6 @@ use starlark_syntax::syntax::type_expr::type_str_literal_is_wildcard;
 
 use crate as starlark;
 use crate::docs::DocFunction;
-use crate::docs::DocItem;
-use crate::docs::DocMember;
 use crate::docs::DocParam;
 use crate::eval::compiler::small_vec_1::SmallVec1;
 use crate::typing::arc_ty::ArcTy;
@@ -476,11 +474,7 @@ impl Ty {
         if let Some(t) = value.get_ref().typechecker_ty() {
             t
         } else {
-            match value.documentation() {
-                Some(DocItem::Member(DocMember::Function(x))) => Ty::from_docs_function(&x),
-                Some(DocItem::Member(DocMember::Property(x))) => x.typ.clone(),
-                _ => value.get_type_starlark_repr(),
-            }
+            value.get_type_starlark_repr()
         }
     }