Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: Mermaid icon #47

Merged
merged 5 commits into from
May 26, 2024
Merged

add: Mermaid icon #47

merged 5 commits into from
May 26, 2024

Conversation

josemateuss
Copy link
Contributor

@josemateuss josemateuss commented May 26, 2024 •
edited
Loading

Add Mermaid Logo #46

Icon ID Icon Image
mermaid image

closes #46

Mermaid: https://mermaid.js.org/

LelouchFR
LelouchFR requested changes May 26, 2024
View reviewed changes
Copy link
Owner

@LelouchFR LelouchFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've inspected your svg, and it seems to be some problem, it's using an image... if you can make that it uses something vectorised would be perfect, to make it the most efficient in terms of usability

@josemateuss
Copy link
Contributor Author

Sure, sorry.

@josemateuss josemateuss requested a review from LelouchFR May 26, 2024 12:56
@josemateuss
Copy link
Contributor Author

please @LelouchFR, can you check again? Thanks.

LelouchFR
LelouchFR approved these changes May 26, 2024
View reviewed changes
Copy link
Owner

@LelouchFR LelouchFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thank you

@LelouchFR LelouchFR merged commit 69cf298 into LelouchFR:main May 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LelouchFR LelouchFR LelouchFR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NEW ICON]: Mermaid
2 participants
@josemateuss @LelouchFR