Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a lot of unnecessary usage of async_trait which can be replaced with standard Rust functionality. This is preferable as less macro usage means faster compilation, and it uses static dispatch (meaning it chooses at compile time which code to execute, unlike async_trait macro which decides at runtime). However the trait definition is a little more verbose as it cannot use
async fn
but use fn with-> impl Future
.