Merge pull request ceph#26220 from ashitakasam/master

common/Formatter: escape printed buffer in XMLFormatter::dump_format_va() Reviewed-by: Kefu Chai <[email protected]>
LeoHubery · Mar 24, 2019 · 62153b3 · 62153b3
2 parents 25ae57b + 99f1d63
commit 62153b3
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/common/Formatter.cc b/src/common/Formatter.cc
@@ -499,7 +499,7 @@ void XMLFormatter::dump_format_va(const char* name, const char *ns, bool quoted,
 
   print_spaces();
   if (ns) {
-    m_ss << "<" << e << " xmlns=\"" << ns << "\">" << buf << "</" << e << ">";
+    m_ss << "<" << e << " xmlns=\"" << ns << "\">" << xml_stream_escaper(std::string_view(buf, len)) << "</" << e << ">";
   } else {
     m_ss << "<" << e << ">" << xml_stream_escaper(std::string_view(buf, len)) << "</" << e << ">";
   }