Code review! #1
Open
Code review! #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to better highlight the small differences between the two functions
You have well-documented functions here: make the docs accessible by formatting them with triply-quoted strings. (See, eg. my_function.func_doc).
It's not generally pythonic to have a "getter" like this - you usually want to just access the object's attributes directly. It looks like you're signalling to the end user that the width and height aren't part of the object's public API. I think it's more clean to skip this (and in fact, I'd change the names from _width and _height to width and height). Others may disagree :)
We found ourselves asking which way transposed was - this naming makes that explicit.
Feel free to be verbose in your variable names in pursuit of readability :)
Refactors edge and distance calculation to avoid confusing (to me) transposition. This commit isn't quite complete/working, but it gives an idea of the direction I'd suggest going. By the way, it's possible to swap two variables in python in one line: b, a = a, b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some thoughts & suggestions. Some of these are half-formed (i.e. I broke your code :), but point in the direction of changes I would make. I'd be happy to talk about these or take another look after you finish your numpy refactoring.