Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: validate from uploaded file #4239

Open
wants to merge 100 commits into
base: main
Choose a base branch
from
Open

feat: validate from uploaded file #4239

wants to merge 100 commits into from

Conversation

vitormattos
Copy link
Member

@vitormattos vitormattos commented Jan 3, 2025 •
edited
Loading

Dependency added:

  • poppler-utils

Was added as fallback to native PHP signature parser.

🏚️ Before 🏡 After
Screenshot_20250102_233051 Screenshot_20250102_232935
Screenshot_20250106_231154
Screenshot_20250106_231009

to-do

  • Implement upload at frontend
  • Create endpoint
  • Add integration tests
  • Match uploaded file with existing files
  • Display data from uploaded file when not matched with existing files
  • Display that have a newest version of uploaded file
  • Details about signer
    • Sign date
    • Certificate chain
  • Show more details about file
    • File size
    • Page counter
    • PDF version
    • Has the file been changed after signing?
    • PDF metadata
    • Signature hash used
    • Load certificate chain using poppler-utils

@vitormattos vitormattos added this to the Next Major (31) milestone Jan 3, 2025
@vitormattos vitormattos self-assigned this Jan 3, 2025
@vitormattos vitormattos changed the title Feat/validate from uploaded file feat: validate from uploaded file Jan 3, 2025
This was referenced Jan 3, 2025
Open
Open
@vitormattos vitormattos force-pushed the feat/validate-from-uploaded-file branch 2 times, most recently from f1d04db to c023f35 Compare January 4, 2025 13:01
@vitormattos
refactor: convert try catch to promisse
1002f10 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
fix: prevent to don't set loading to false when don't upload file
24a887a 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
refactor: convert to native typed properties
7526749 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
fix: use UID as uppercase
11f16b1 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
feat: store hash of signed file at database
f900fa8 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
feat: add new endpoint to validate from uploaded file
214f4c2 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
chore: update documentation
859df10 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
feat: update validation page to add validate from uploaded file
92aa3dd 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
fix: cs
07d39d3 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
fix: ignore error
af51c3d 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
chore: reorder methods and rename internal method
054d0e5 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
chore: add new status
d013ffb 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
fix: revert previous change
16dd18c 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
fix: previous commit
9fa0910 
Is necessary to identify the file to parse from UUID.

Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
refactor: change methods structure
4dcdb18 
A step to be possible choose what kind of metadata I want

Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
fix: only need to get content from file when haven't a LibreSign file
fb88965 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
feat: add totalPages to return of validate method
756263d 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
fix: remove request to validation API when load validation page
db12697 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
fix: app id
0079f3c 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
fix: remove request to validation api when open validation page
7e2f74d 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
chore: make possible use the class "extra" at other section scope
78d7ad1 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
chore: convert document name to list item
9d5cb1f 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
feat: display total pages of a pdf file
574e4ec 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
chore: only show sign date when have this information
9c257f3 
The file could be not signed

Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
chore: get filename from uploaded file
123acf7 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
fix: get common name from subject
b681022 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
chore: change order to call method
5ddab9b 
This method trigger loadSigners internally, because this was moved to
the final of flow and also because the loadSigned could generate new
messages

Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
chore: remove unecessary condition
ed2e0fa 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
fix: key of signed data
4a7c25d 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
chore: lazy load of content
f0df1e1 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
fix: translate text
5437d73 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
feat: show issuer
28db566 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
feat: display hash algorithm
c9f14e3 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos vitormattos force-pushed the feat/validate-from-uploaded-file branch from 37e5cba to 1ecff7b Compare January 6, 2025 23:37
@vitormattos
refactor: make more readdable
afd602a 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos vitormattos force-pushed the feat/validate-from-uploaded-file branch from 1ecff7b to afd602a Compare January 6, 2025 23:37
@vitormattos
feat: add poppler-utils as fallback signature validator
68e317d 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
feat: implement loading to validate actions
314285d 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
fix: cs
42057d5 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
fix: don't throw error when is not a LibreSign file
7e28dd6 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
fix: only remove loading when finish the validation
90d8e65 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
fix: linter
de07b02 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
fix: add name
dc5ecf4 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
fix: linter
7702e1b 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
chore: fallback to sign date
f9d2346 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
chore: parse status text
f838355 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
chore: indent certificate chain
d361cfe 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
feat: implement poppler pdfsig configuration check
a489606 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
fix: merge two results of parse
f3975ae 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
chore: add poppler-utils at tests
784b751 
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos vitormattos force-pushed the feat/validate-from-uploaded-file branch from 49ac7fb to 784b751 Compare January 8, 2025 17:54
@vitormattos
fix: typo
8563759 
removed typo that was added to be possible validate when pdfsig don't
exists

Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos
chore: mark validation test as skipped if haven't poppler-utils
821f43c 
Signed-off-by: Vitor Mattos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vitormattos vitormattos

Labels
None yet
Projects
Roadmap
Status: 0. Needs triage
Milestone
Next Major (31)
Development

Successfully merging this pull request may close these issues.
1 participant
@vitormattos