test else clause in requiredProperty

Lighthouse-io · Jul 7, 2016 · fb63157 · fb63157
1 parent f3d6396
commit fb63157
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 18 deletions.
diff --git a/object.js b/object.js
@@ -214,24 +214,6 @@ function hint(gj, options) {
  }
  }
 
-
- function rightHandRule (geometry) {
- var rhr = true;
- if (geometry.type == 'Polygon') {
- rhr = isPolyRHR(geometry.coordinates);
- } else if (geometry.type == 'MultiPolygon') {
- if (!geometry.coordinates.every(isPolyRHR))
- rhr = false;
- }
- if (!rhr) {
- errors.push({
- message: 'Polygons and MultiPolygons should follow the right-hand rule',
- level: 'warn',
- line: geometry.__line__
- });
- }
- }
-
  function rightHandRule (geometry) {
  var rhr = true;
  if (geometry.type == 'Polygon') {

diff --git a/test/data/bad/expected_object.geojson b/test/data/bad/expected_object.geojson
@@ -0,0 +1 @@
+{"type": "Feature", "properties": 123, "geometry": null}
diff --git a/test/data/bad/expected_object.result b/test/data/bad/expected_object.result
@@ -0,0 +1,6 @@
+[
+{
+ "line": 1,
+ "message": "\"properties\" property should be object, but is an number instead"
+}
+]
diff --git a/test/data/bad/expected_object.result-object b/test/data/bad/expected_object.result-object
@@ -0,0 +1,5 @@
+[
+{
+ "message": "\"properties\" property should be object, but is an number instead"
+}
+]