Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blessing priorities. #356

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JerryLingjieMei
Copy link
Contributor

#347 Automatically select the blessings with the highest rarity within each priority group.

@LmeSzinc
Copy link
Owner

LmeSzinc commented Mar 5, 2024

Not accepted. Filters parsing must follow the given filters, no rarity priority should be added if filter don't have a rarity priority.

@LmeSzinc LmeSzinc added feature request / 功能请求 New feature or requests good first issue / 首次贡献 Good for newcomers labels Mar 5, 2024
@JerryLingjieMei
Copy link
Contributor Author

Not accepted. Filters parsing must follow the given filters, no rarity priority should be added if filter don't have a rarity priority.

Under most circumstances, higher rarity blessings are usually better than lower rarity blessings when under the same filter group. For example, the user may not want to specify explicitly that nihility-3>nihility-2, hunt-3>hunt-2, and random-3>random-2, etc.; they only need to state nihility>hunt>(champion dinner)> reset>random.

@LmeSzinc
Copy link
Owner

This is a code quality thing, business code should be separated from non-business code. Filter class is a general class for filter string parsing, there shouldn't be a new argument added just for one business scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants