Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full support for required custom modifiers #160

Closed
wants to merge 5 commits into from
Closed

Full support for required custom modifiers #160

wants to merge 5 commits into from

Conversation

OlegRa
Copy link
Collaborator

@OlegRa OlegRa commented May 8, 2022

This PR contains changes from PR #145 with appropriate fixes and similar changes that fixes #119 (same root cause).

@OlegRa OlegRa requested a review from vermorel May 8, 2022 11:32
@OlegRa OlegRa added the bug Something isn't working label May 8, 2022
@OlegRa OlegRa reopened this May 8, 2022
@@ -88,5 +88,15 @@ public async void AnotherMethodWithDefaultParameterValues()
"var r = x.AnotherMethodWithDefaultParameterValues(2, \"\", \"\", 27);",
"r"));
}

[Fact]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superfluous line break. I will remove on myself on merge.

Copy link
Member

@vermorel vermorel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

vermorel pushed a commit that referenced this pull request May 8, 2022
@vermorel
Copy link
Member

vermorel commented May 8, 2022

@OlegRa I have done the merge manually. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to deserialize: volatile field reference
3 participants