Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make system_tray actually use installed icons on Linux Flatpak #236

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

Fei1Yang
Copy link
Contributor

@Fei1Yang Fei1Yang commented Jan 14, 2025

Note: this pull request is depended on Losses/system_tray#1

The system_tray package currently will rewrite iconPath to it's absolute path, this pull request series allow installed icons to able to be used.

Summary by Sourcery

Update the system tray icon handling to use installed icons when available on Linux Flatpak.

Copy link

sourcery-ai bot commented Jan 14, 2025

Reviewer's Guide by Sourcery

This pull request updates the system tray icon handling to use installed icons when available on Linux Flatpak.

Sequence diagram for system tray icon initialization and update

sequenceDiagram
    participant App
    participant TrayManager
    participant TrayIcon
    participant SystemTray
    App->>TrayManager: getTrayIcon()
    TrayManager->>TrayIcon: create(path, isInstalled)
    TrayIcon-->>TrayManager: icon
    TrayManager-->>App: icon
    App->>SystemTray: initSystemTray(icon.path, isInstalled: icon.isInstalled)
    Note over SystemTray: Initialize with proper icon settings
    App->>TrayManager: updateTrayIcon()
    TrayManager->>TrayManager: getTrayIcon()
    TrayManager->>SystemTray: setImage(icon.path, isInstalled: icon.isInstalled)
Loading

File-Level Changes

Change Details Files
Introduce a new TrayIcon class to encapsulate icon path and installation status.
  • Created the TrayIcon class with path and isInstalled fields.
  • Modified getTrayIconPath to getTrayIcon, returning a TrayIcon object.
  • Updated usages of getTrayIconPath to use getTrayIcon and access the path and isInstalled properties of the returned TrayIcon object.
lib/utils/tray_manager.dart
Update system tray initialization to use installed icons.
  • Added isInstalled parameter to systemTray.initSystemTray and systemTray.setImage.
  • Pass the isInstalled property of the TrayIcon object to systemTray.initSystemTray and systemTray.setImage.
lib/main.dart
lib/utils/tray_manager.dart
Update system_tray dependency to use the latest version.
  • Updated the system_tray dependency in pubspec.yaml to point to a specific commit that includes the necessary changes for using installed icons.
  • Updated pubspec.lock to reflect the changes in pubspec.yaml.
pubspec.yaml
pubspec.lock

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@Fei1Yang Fei1Yang marked this pull request as ready for review January 14, 2025 05:47
@Losses Losses merged commit 28d444b into Losses:master Jan 14, 2025
1 of 2 checks passed
@dosubot dosubot bot added C - bug Something isn't working P - Linux Linux system related issue labels Jan 14, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Fei1Yang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C - bug Something isn't working P - Linux Linux system related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants