Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve /pos and /play indexing, labeling + fix demo/cutscene titles #2606

Merged
merged 7 commits into from
Mar 11, 2025

Conversation

rr-
Copy link
Collaborator

@rr- rr- commented Mar 11, 2025

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change
  • I have added a readme entry about my new feature or OG bug fix, or it is a different change

Description

Resolves #2604. Resolves #2605.

@rr- rr- added TRX bug A bug with TRX Enhancement Improvement of an existing feature TR2 TR1 labels Mar 11, 2025
@rr- rr- self-assigned this Mar 11, 2025
@rr- rr- requested review from a team as code owners March 11, 2025 20:40
@rr- rr- requested review from lahm86, walkawayy and aredfan and removed request for a team March 11, 2025 20:40
@walkawayy
Copy link
Collaborator

TR1, UB, and TR2 LGTM. I don't have Golden Mask installed which I should get on.

My only comment is you can use play 21 in TR1 for example and it loads the title screen and says Loading Current Position. I know it's a legacy level thing that exists, but I just wanted to mention it in case.

image

@aredfan
Copy link
Collaborator

aredfan commented Mar 11, 2025

The console logs in demos and cutscenes now display the titles as expected, thank you.

The /pos command remains unavailable during TR1 cutscenes.

@rr-
Copy link
Collaborator Author

rr- commented Mar 11, 2025

I included a check to avoid repeating itself so it now says Cutscene 3 Room: 0 rather than Cutscene 3 (Cut Scene 3) Room: 0. Also went with a Cutscene wording.

@rr- rr- merged commit d667b13 into develop Mar 11, 2025
9 checks passed
@rr- rr- deleted the demo-titles branch March 11, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement of an existing feature TR1 TR2 TRX bug A bug with TRX
Projects
Status: Done
4 participants