Chore: Remove redis backed reporting (chatwoot#669)

LucasPonzo · May 2, 2020 · 7e62000 · 7e62000
1 parent ddbc612
commit 7e62000
Show file tree

Hide file tree

Showing 13 changed files with 2 additions and 322 deletions.
diff --git a/Gemfile b/Gemfile
@@ -54,9 +54,6 @@ gem 'pundit'
 # https://karolgalanciak.com/blog/2019/11/30/from-activerecord-callbacks-to-publish-slash-subscribe-pattern-and-event-driven-design/
 gem 'wisper', '2.0.0'
 
-##--- gems for reporting ---##
-gem 'nightfury'
-
 ##--- gems for billing ---##
 gem 'chargebee'
 

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -282,7 +282,6 @@ GEM
  multi_xml (0.6.0)
  multipart-post (2.1.1)
  netrc (0.11.0)
- nightfury (1.0.1)
  nio4r (2.5.2)
  nokogiri (1.10.9)
  mini_portile2 (~> 2.4.0)
@@ -533,8 +532,7 @@ DEPENDENCIES
  letter_opener
  listen
  mini_magick
- mock_redis!
- nightfury
+ mock_redis
  pg
  pry-rails
  puma

diff --git a/app/builders/report_builder.rb b/app/builders/report_builder.rb
diff --git a/app/controllers/api/v1/accounts/reports_controller.rb b/app/controllers/api/v1/accounts/reports_controller.rb
diff --git a/app/dispatchers/async_dispatcher.rb b/app/dispatchers/async_dispatcher.rb
@@ -9,7 +9,7 @@ def publish_event(event_name, timestamp, data)
  end
 
  def listeners
- listeners = [EventListener.instance, ReportingListener.instance, WebhookListener.instance]
+ listeners = [EventListener.instance, WebhookListener.instance]
  listeners << SubscriptionListener.instance if ENV['BILLING_ENABLED']
  listeners
  end

diff --git a/app/identities/account_identity.rb b/app/identities/account_identity.rb
diff --git a/app/identities/agent_identity.rb b/app/identities/agent_identity.rb
diff --git a/config/initializers/redis.rb b/config/initializers/redis.rb
@@ -3,7 +3,6 @@
  password: ENV.fetch('REDIS_PASSWORD', nil).presence
 }
 redis = Rails.env.test? ? MockRedis.new : Redis.new(app_redis_config)
-Nightfury.redis = Redis::Namespace.new('reports', redis: redis)
 
 # Alfred - Used currently for round robin and conversation emails.
 # Add here as you use it for more features

diff --git a/config/reports_redis.yml b/config/reports_redis.yml
diff --git a/config/routes.rb b/config/routes.rb
@@ -79,17 +79,6 @@
  resources :notifications, only: [:index, :update]
  resource :notification_settings, only: [:show, :update]
 
- resources :reports, only: [] do
- collection do
- get :account
- get :agent
- end
- member do
- get :account_summary
- get :agent_summary
- end
- end
-
  # this block is only required if subscription via chargebee is enabled
  resources :subscriptions, only: [:index] do
  collection do

diff --git a/lib/constants/report.rb b/lib/constants/report.rb
diff --git a/lib/custom_exceptions/report.rb b/lib/custom_exceptions/report.rb
diff --git a/spec/listeners/reporting_listener_spec.rb b/spec/listeners/reporting_listener_spec.rb