Skip to content

Commit

Permalink
Remove .[minimum-jaxlib] from test-requirements.txt
Browse files Browse the repository at this point in the history
This means that jax and its dependencies (e.g. jaxlib) must be
manually installed before running the tests. This is useful for
testing an existing jax install, e.g. a later version of jaxlib, GPU
jaxlib, etc.
  • Loading branch information
skye committed Sep 23, 2021
1 parent be34a14 commit 2fcf3f7
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/ci-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,9 @@ jobs:
pip install ${{ matrix.package-overrides }}
fi
if [ "${{ matrix.use-latest-jaxlib }}" == "true" ]; then
pip install -e .[cpu]
pip install .[cpu]
else
pip install .[minimum-jaxlib]
fi
- name: Run tests
Expand Down
2 changes: 0 additions & 2 deletions build/test-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,3 @@ pillow>=8.3.1
pytest-benchmark
pytest-xdist
wheel
# Install jax from the current directory with minimum jaxlib from pypi.
.[minimum-jaxlib]
4 changes: 2 additions & 2 deletions docs/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Follow these steps to contribute code:
git clone https://github.com/YOUR_USERNAME/jax
cd jax
pip install -r build/test-requirements.txt # Installs all testing requirements.
pip install -e . # Installs JAX from the current directory in editable mode.
pip install -e .[cpu] # Installs JAX from the current directory in editable mode.
```

4. Add the JAX repo as an upstream remote, so you can use it to sync your
Expand Down Expand Up @@ -91,7 +91,7 @@ Follow these steps to contribute code:
git rebase upstream/main
```

Finally, push your commit on your development branch and create a remote
Finally, push your commit on your development branch and create a remote
branch in your fork that you can use to create a pull request from:

```bash
Expand Down

0 comments on commit 2fcf3f7

Please sign in to comment.