Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View configuration according the status #29

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

luca-c-xcv
Copy link
Member

Add a flag in the configuration to know whether a configuration is in use or not. Also use it to display the correct connection: during connection display only unconnected interfaces, during disconnection display only connected interfaces.

Fixes: #24

Description

A couple of functions have been added to get the list of connections by their status from the configuration file and to set it in the same file.

Motivation and Context

Reduce the list of configurations when possible and avoid errors caused by incorrect usage

How Has This Been Tested?

Testing the function calling them by a test

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality
    to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@luca-c-xcv luca-c-xcv requested a review from a team February 27, 2025 16:52
@luca-c-xcv luca-c-xcv self-assigned this Feb 27, 2025
@luca-c-xcv luca-c-xcv added the enhancement New feature or request label Feb 27, 2025
Add a flag in the configuration to know whether a configuration is in use or
not. Also use it to display the correct connection: during connection display
only unconnected interfaces, during disconnection display only connected
interfaces.

Fixes: LunaticFringers#24

Signed-off-by: Luca Canessa<[email protected]>
Copy link
Member

@giubacc giubacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@luca-c-xcv luca-c-xcv merged commit 5b9e2bb into LunaticFringers:main Feb 28, 2025
1 check passed
@luca-c-xcv luca-c-xcv deleted the feature/connected branch February 28, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEATURE] View connected
2 participants