Properly Scale Menu Assets (RenderTexture2D scaling) #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyall
requested changes
Feb 15, 2024
Co-authored-by: Lyall <[email protected]>
Lyall
approved these changes
Feb 15, 2024
|
Okay I think this all good to be merged now. I'll have a look at 1080p rect issue, I think I know where to possibly fix that. |
Lyall
added a commit
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The context for this PR is in issue #17. This PR seems to work in my testing, besides some minor visual issues that are not directly caused by RenderTexture2D. A quick example: https://youtu.be/RFTeLMdHlR8
At this point, it may be worth making some further changes, such as more verbose support for
fRenTexResMultiXwithin the config file. (Though using fRenTexResMultiX may have bogus results at some point)This could also use far more testing, as they may be issues that I have yet to see, which are related to how I chose to scale the RenderTexture2Ds.