Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): do not pack devDependencies modules #221

Merged

Conversation

cettoana
Copy link
Member

node_modules folder difference in production (per platform)

  • 108 MB -> 70 MB
  • about 17000 files -> about 5200 files

@codecov
Copy link

codecov bot commented Oct 26, 2017

Codecov Report

Merging #221 into admin-user will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           admin-user    #221   +/-   ##
==========================================
  Coverage        2.59%   2.59%           
==========================================
  Files             156     156           
  Lines            2234    2234           
  Branches          200     200           
==========================================
  Hits               58      58           
  Misses           1977    1977           
  Partials          199     199

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f6547b...11ef34c. Read the comment docs.

@cettoana cettoana merged commit fedfabe into admin-user Oct 27, 2017
@cettoana cettoana deleted the chore/do-not-pack-devDependencies-modules-on-build branch October 27, 2017 08:04
cettoana added a commit that referenced this pull request Nov 2, 2017
* adjust isAdmin rule
* bugfix(admin): content-type issue for upload csv. (#188)
* bugfix(admin): content-type issue for upload csv.
* bug(admin): do not use key to get request body.
* bugfix(admin): parse the new line with both /r and /n. (#189)
* fixed delete user bugs
* clear data feature
* Merge mysql to admin-user (#208)
* fix(DB): change default DB back to NeDB. (#209)
* fix(admin/user): response error message when csv format error/user existed (#210)
* fix(admin): clear all data api (#211)
* fix(unittype): unittype query always empty
* fix: clear all data under NeDB
* add: clear all data under MySQL
* fix(app): random crashes on restart lite server (#213)
* feature(Users): user email available check API (#214)
* fix(admin/user): retrieve user list with mysql (#216)
* remove stream server (#217)
* fix(server): port binding failure on restart server (#220)
*  fix(datachannels): add hasHistory entry for datachannels (#223)
* fix(datachannel): add historical datapoints supported indication fro nedb
* fix(datachannels): update schema for mysql
* chore(build): do not pack devDependencies modules (#221)
* fix(migration): use path.resolve to get absolute path of NeDB JSON files (#226)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant