Fixes database offset tests (laravel#37163)

MSR2012 · Apr 28, 2021 · 48af1c9 · 48af1c9
1 parent 647d5aa
commit 48af1c9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/Illuminate/Database/Query/Builder.php b/src/Illuminate/Database/Query/Builder.php
@@ -2065,7 +2065,7 @@ public function offset($value)
     {
         $property = $this->unions ? 'unionOffset' : 'offset';
 
-        $this->$property = max(0, $value);
+        $this->$property = max(0, (int) $value);
 
         return $this;
     }

diff --git a/tests/Database/DatabaseQueryBuilderTest.php b/tests/Database/DatabaseQueryBuilderTest.php
@@ -2913,7 +2913,11 @@ public function testSqlServerLimitsAndOffsets()
 
         $builder = $this->getSqlServerBuilder();
         $builder->select('*')->from('users')->take('foo')->offset('bar');
-        $this->assertSame('select * from (select *, row_number() over (order by (select 0)) as row_num from [users]) as temp_table where row_num between 1 and 0 order by row_num', $builder->toSql());
+        $this->assertSame('select * from [users]', $builder->toSql());
+
+        $builder = $this->getSqlServerBuilder();
+        $builder->select('*')->from('users')->offset('bar');
+        $this->assertSame('select * from [users]', $builder->toSql());
     }
 
     public function testMySqlSoundsLikeOperator()