Skip to content

Commit

Permalink
Bump lots of deps
Browse files Browse the repository at this point in the history
  • Loading branch information
reZach committed Sep 10, 2021
1 parent 91212f7 commit ff988a0
Show file tree
Hide file tree
Showing 7 changed files with 2,558 additions and 6,662 deletions.
10 changes: 6 additions & 4 deletions dev-scripts/launchDevServer.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,12 @@ const intervalId = setInterval(function () {
encoding: "utf8"
});

// "Compiled successfully." is the string we need to find
// "compiled successfully" is the string we need to find
// to know that webpack is done bundling everything and we
// can load our Electron app with no issues.
if (log.indexOf("Compiled successfully.") >= 0) {
// can load our Electron app with no issues. We split up the
// validation because the output contains non-standard characters.
const compiled = log.indexOf("compiled");
if (compiled >= 0 && log.indexOf("successfully", compiled) >= 0) {
console.log("Webpack development server is ready, launching Electron app.");
clearInterval(intervalId);

Expand All @@ -29,7 +31,7 @@ const intervalId = setInterval(function () {
electronProcess.stderr.on("data", function(data) {
process.stdout.write(data);
});
} else if (log.indexOf("Failed to compile.") >= 0) {
} else if (log.indexOf("Module build failed") >= 0) {

if (fs.existsSync(errorLogFilePath)) {
const errorLog = fs.readFileSync(errorLogFilePath, {
Expand Down
3 changes: 3 additions & 0 deletions docs/faq.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,8 @@ Yes, but you'll have to follow [a few steps](https://github.com/reZach/secure-el
## How do I set up my own license keys?
Please refer to [these instructions](https://github.com/reZach/secure-electron-license-keys) first. If you have further questions, you may post a question in the appropriate repo.

## Can I use typescript with this template?
I suggest following [this pull request](https://github.com/tyler-hitzeman/secure-electron-template-ts/pull/1) to guide you what changes you'll need to make.

#### Question not answered?
Please [post an issue](https://github.com/reZach/secure-electron-template/issues/new) and we will add to this page with questions that you have!
Binary file modified docs/imgs/intro.gif
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading

0 comments on commit ff988a0

Please sign in to comment.