There can be only one autoloader: zeitwerk #22801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrafanie
changed the title
jrafanie
added a commit
to jrafanie/manageiq-automation_engine
that referenced
this pull request
Dec 4, 2023
This was only needed for classic autoloader. The core "freedom" patch made zeitwerk autoloader bypass the interlock anyway, so now that we're only supporting zeitwerk, this is no longer needed. Co-dependency: ManageIQ/manageiq#22801 Part of the rails 7 upgrade: ManageIQ/manageiq#22052
jrafanie
added a commit
to jrafanie/manageiq-api
that referenced
this pull request
Dec 4, 2023
This was only needed for classic autoloader. The core "freedom" patch made zeitwerk autoloader bypass the interlock anyway, so now that we're only supporting zeitwerk, this is no longer needed. Co-dependency: ManageIQ/manageiq#22801 Part of the rails 7 upgrade: ManageIQ/manageiq#22052
jrafanie
added a commit
to jrafanie/manageiq-api
that referenced
this pull request
Dec 4, 2023
This was only needed for classic autoloader. The core "freedom" patch made zeitwerk autoloader bypass the interlock anyway, so now that we're only supporting zeitwerk, this is no longer needed. Co-dependency: ManageIQ/manageiq#22801 Part of the rails 7 upgrade: ManageIQ/manageiq#22052
|
@miq-bot cross-repo-tests #22801 ManageIQ/manageiq-api#1243 ManageIQ/manageiq-automation_engine#537 |
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Dec 4, 2023
From Pull Request: ManageIQ/manageiq#22801
jrafanie
changed the title
jrafanie
added a commit
to jrafanie/manageiq-automation_engine
that referenced
this pull request
Dec 18, 2023
This was only needed for classic autoloader. The core "freedom" patch made zeitwerk autoloader bypass the interlock anyway, so now that we're only supporting zeitwerk, this is no longer needed. Co-dependency: ManageIQ/manageiq#22801 Part of the rails 7 upgrade: ManageIQ/manageiq#22052
Part of the rails 7 upgrade: ManageIQ#22052
Part of the rails 7 upgrade: ManageIQ#22052
We can't dynamically modify the autoload_paths from within the test when zeitwerk is the autoloader. Part of the rails 7 upgrade: ManageIQ#22052
jrafanie
force-pushed
the
there_can_be_only_one_autoloader_zeitwerk
branch
from
803e368 to
fb5f6e8
Compare
|
Some comments on commits jrafanie/manageiq@333ab09~...fb5f6e8 config/initializers/zeitwerk.rb
|
|
Checked commits jrafanie/manageiq@333ab09~...fb5f6e8 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
|
This is ready to go since we were already defaulting to zeitwerk on quinteros |
|
@jrafanie Do you want this on quinteros? |
|
Backported to |
Fryguy
added a commit
that referenced
this pull request
Jan 5, 2024
…der_zeitwerk There can be only one autoloader: zeitwerk (cherry picked from commit 7a3c4a6)
This was referenced Jan 24, 2024
Closed
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the rails 7 upgrade: #22052
Should be merged with:
Cross repo test: