Fix duplicate references in scene.mobjects
after ReplacementTransform
with existing target mobject
#4242
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Fix #4238
Fix duplicate mobject reference issue when using
ReplacementTransform
Motivation and Explanation: Why and how do your changes improve the library?
Previously, if the target mobject was already in the scene,
ReplacementTransform
would replace the source mobject in thescene.mobjects
list without removing the existing reference to the target mobject. This causedscene.mobjects
to contain two references to the same object (i.e., the target mobject), leading to unexpected behavior in #4238.Before this fix:
After this fix:
Reviewer Checklist