rpl_start/stop_server.inc fixes
#3849
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `rpl_stop_server.inc`: re. “can’t use `begin`/`end_include_file”, (re)define `$_include_file_depth= 0` in case this is the first `--source` in a `rpl_init.inc`-less setup (e.g., `multi_source.*`) * `rpl_start_server.inc`: move the `end_include_file.inc` call out of `if (!$rpl_server_error)` to always close the `begin_include_file.inc` * `rpl_reconnect.inc` (called by rpl_start_server.inc`): skip reconnecting ‘master/slave’ aliases of `server_*` to lift its practical requirement of `master-slave.inc` (It failed with “no connection named master/slave” for even a `rpl_init.inc` setup, let alone `rpl_init`-less.)
|
So there are no connection aliases, only duplicate connections to the same set of servers? |
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Jira issue number for this PR is: MDEV-______Description
rpl_stop_server.inc: re. “can’t usebegin/end_include_file”, (re)define$_include_file_depth= 0in case this is the first--sourcein arpl_init.inc-less setup (e.g.,multi_source.*)rpl_start_server.inc: move theend_include_file.inccall out ofif (!$rpl_server_error)to always close thebegin_include_file.incrpl_reconnect.inc(called by rpl_start_server.inc): skip reconnecting ‘master/slave’ aliases ofserver_*to lift its practical requirement ofmaster-slave.inc(It failed with “no connection named master/slave” for even arpl_init.incsetup, let alonerpl_init`-less.)Release Notes
Do our users even use our
include/*.incs?How can this PR be tested?
PR quality check
mainbranch.