Skip to content

Commit

Permalink
build: Run docs and lint on py38
Browse files Browse the repository at this point in the history
This requires moving some noqa comments due to 3.8's changes to the
ast module.
  • Loading branch information
bdarnell committed Nov 23, 2019
1 parent 1418880 commit 29b1999
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 12 deletions.
4 changes: 2 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ jobs:
- python: nightly
env: TOX_ENV=py3-full
# Docs and lint python versions must be synced with those in tox.ini
- python: '3.7'
- python: '3.8'
env: TOX_ENV=docs
- python: '3.6'
- python: '3.8'
env: TOX_ENV=lint

install:
Expand Down
8 changes: 4 additions & 4 deletions tornado/ioloop.py
Original file line number Diff line number Diff line change
Expand Up @@ -233,13 +233,13 @@ def clear_instance() -> None:
def current() -> "IOLoop":
pass

@typing.overload # noqa: F811
@typing.overload
@staticmethod
def current(instance: bool = True) -> Optional["IOLoop"]:
def current(instance: bool = True) -> Optional["IOLoop"]: # noqa: F811
pass

@staticmethod # noqa: F811
def current(instance: bool = True) -> Optional["IOLoop"]:
@staticmethod
def current(instance: bool = True) -> Optional["IOLoop"]: # noqa: F811
"""Returns the current thread's `IOLoop`.
If an `IOLoop` is currently running or has been marked as
Expand Down
8 changes: 4 additions & 4 deletions tornado/web.py
Original file line number Diff line number Diff line change
Expand Up @@ -424,14 +424,14 @@ def _convert_header_value(self, value: _HeaderTypes) -> str:
def get_argument(self, name: str, default: str, strip: bool = True) -> str:
pass

@overload # noqa: F811
def get_argument(
@overload
def get_argument( # noqa: F811
self, name: str, default: _ArgDefaultMarker = _ARG_DEFAULT, strip: bool = True
) -> str:
pass

@overload # noqa: F811
def get_argument(
@overload
def get_argument( # noqa: F811
self, name: str, default: None, strip: bool = True
) -> Optional[str]:
pass
Expand Down
4 changes: 2 additions & 2 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ basepython =
# the outputs of the tools (especially where exactly the
# linter warning-supression comments go), so we specify a
# python version for these builds.
docs: python3.7
lint: python3.6
docs: python3.8
lint: python3.8

deps =
full: pycurl
Expand Down

0 comments on commit 29b1999

Please sign in to comment.