SdfWriter::write format_delay_ possible overflow

Signed-off-by: James Cherry <[email protected]>
MeaquaZZ · Jan 13, 2022 · 4e0d2d9 · 4e0d2d9
1 parent 2befa80
commit 4e0d2d9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/liberty/LibertyParser.cc b/liberty/LibertyParser.cc
@@ -336,11 +336,9 @@ makeLibertyComplexAttr(const char *name,
         group->addAttribute(attr);
         return attr;
       }
-      else {
-        delete attr;
-        return nullptr;
-      }
     }
+    delete attr;
+    return nullptr;
   }
 }
 

diff --git a/sdf/SdfWriter.cc b/sdf/SdfWriter.cc
@@ -164,8 +164,7 @@ SdfWriter::write(const char *filename,
   sdf_divider_ = sdf_divider;
   include_typ_ = include_typ;
   if (delay_format_ == nullptr)
-    delay_format_ = new char[10];
-  sprintf(delay_format_, "%%.%df", digits);
+    delay_format_ = stringPrint("%%.%df", digits);
 
   LibertyLibrary *default_lib = network_->defaultLibertyLibrary();
   timescale_ = default_lib->units()->timeUnit()->scale();