Issue: 4332286 Release path change and source_rpms semilink #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NirWolfer
force-pushed
the
HPCINFRA-3267
branch
from
a7e378c to
cbd0ae7
Compare
NirWolfer
changed the title
|
bot:retest |
|
bot:rm:retest |
Change release folder name from libvma_v_<version> to vma_v_<version> Create semilink from package release folder to source_rpms folder. issue: 4332286 Signed-off-by: NirWolfer <[email protected]>
NirWolfer
force-pushed
the
HPCINFRA-3267
branch
from
cbd0ae7 to
0826ac2
Compare
|
bot:rm:restest |
|
bot:retest |
dpressle
requested changes
Feb 27, 2025
.ci/do_release.sh
Outdated
|
|
||
| cd pkg/packages || { echo "pkg folder is missing, exiting..."; exit 1; } | ||
| pkg_name=$(ls -1 libvma-"${release_tag}"-"${revision}".src.rpm) | ||
| DST_DIR=${release_folder}/libvma_v_${release_tag}-0/src | ||
| DST_DIR=${release_folder}/vma_v_${release_tag}-0/src |
There was a problem hiding this comment.
can you have this define before line 60 and use it in line 60 instead of duplicating it?
|
bot:retest |
issue: 4332286
NirWolfer
force-pushed
the
HPCINFRA-3267
branch
from
8b803ab to
46f4a59
Compare
|
bot:retest |
dpressle
requested changes
Feb 27, 2025
|
|
||
| cd pkg/packages || { echo "pkg folder is missing, exiting..."; exit 1; } | ||
| pkg_name=$(ls -1 libvma-"${release_tag}"-"${revision}".src.rpm) | ||
| DST_DIR=${release_folder}/libvma_v_${release_tag}-0/src | ||
| DST_DIR=${release_folder}/${package_folder}/src |
There was a problem hiding this comment.
But its still the same text as in line 61, why cant you just move this line above line 61 and use DST_DIR in echo?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The name of the folder created for the package in the release process is wrong, and there is no link created to the package under source_rpms
What
Change release folder name from libvma_v_ to vma_v_
Create semilink from package release folder to source_rpms folder.
Why ?
Issue: HPCINFRA-3267
How ?
It is optional but for complex PRs please provide information about the design,
architecture, approach, etc.
Change type
What kind of change does this PR introduce?
Check list