Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for strong-cupcake-4268bc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jeheecheon
approved these changes
Jan 4, 2025
src/components/Input/LabelInput.tsx
Outdated
| ...props | ||
| }) => { | ||
| return ( | ||
| <div className={cn(`(LabelInputVariant) w-full`, className)} {...props}> |
There was a problem hiding this comment.
요기 (LabelInputVariant) 깜빡하구 못 지운듯?!
src/components/Input/LabelInput.tsx
Outdated
|
|
||
| const LabelInputVariant = cva('w-full text-left', { | ||
| variants: { | ||
| variants: { |
There was a problem hiding this comment.
별 거 아니긴 한데 요기 단수로 네이밍하는 게 좋을 것 같음!
There was a problem hiding this comment.
ㅇㅇㅇ맞으 위에 Input은 variant 이길래 살짝 일관되게 해주면 좋을 것 같아서👍
src/components/Input/LabelInput.tsx
Outdated
| variants: { | ||
| primary: 'mb-1.5 font-normal text-gray-1', | ||
| }, | ||
| labelsize: { |
| @@ -25,5 +25,4 @@ const RootLayout: React.FC<RootLayoutProps> = ({ children }) => { | |||
| </html> | |||
| ); | |||
| }; | |||
|
|
|||
jeheecheon
approved these changes
Jan 6, 2025
| type: 'text', | ||
| placeholder: 'Input with error', | ||
| error: 'This field is required', | ||
| className: 'border-red-500', // 에러 시 빨간 테두리 |
There was a problem hiding this comment.
어차피 나중에 디자인 싹 ㅂ바뀔거라서 상관없긴 한데 바깥에서 Input 컴포넌트 사용할 때에는 스타일 색상 관련해서 className보다는 props으로만 하는 게 좋음
Comment on lines
+48
to
+55
| <label className={cn(LabelInputVariant({ labelSize }))}>{label}</label> | ||
| <Input | ||
| type={type} | ||
| size={size} | ||
| rounded={rounded} | ||
| error={error} | ||
| placeholder={placeholder} | ||
| /> |
There was a problem hiding this comment.
놓치고 확인을 못 했는데 htmlFor 로 Input 태그랑 연결해주느 게 좋음. 이때는 useId 써도 좋을듯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 PR Summary
🤔 NOTE
🔗 Related Issues
x