Skip to content

Commit

Permalink
Explicitly set var and obs columns while filtering with counts. (open…
Browse files Browse the repository at this point in the history
…pipelines-bio#262)

* Explicitly set var and obs columns while filtering with counts

* Add CHANGELOG
  • Loading branch information
DriesSchaumont authored Feb 3, 2023
1 parent 1e9f1c6 commit 9192dbe
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 4 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ These options were previously covered in the `bin/init` script, but this new fea

* `filter/do_filter`: resolved an issue where the .obs column instead of the .var column was being logged when filtering using the .var column.

* `workflows/rna_singlesample` and `workflows/prot_singlesample`: Correctly set var and obs columns while filtering with counts.

* `filter/do_filter`: removed the default input value for `var_filter` argument.

# openpipelines 0.6.2
Expand Down
13 changes: 11 additions & 2 deletions workflows/multiomics/prot_singlesample/main.nf
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,20 @@ workflow run_wf {
// filtering
| getWorkflowArguments(key: "filter_with_counts")
| filter_with_counts.run(
args: [ var_gene_names: "gene_symbol", modality: "prot"]
args: [
var_gene_names: "gene_symbol",
modality: "prot",
obs_name_filter: "filter_with_counts",
var_name_filter: "filter_with_counts"
]
)
| getWorkflowArguments(key: "do_filter")
| do_filter.run(
args: [ obs_filter: "filter_with_counts", modality: "prot" ]
args: [
obs_filter: "filter_with_counts",
modality: "prot",
var_filter: "filter_with_counts"
]
)
| map {list -> [list[0], list[1]] + list.drop(3)}
| view { "Output: $it" }
Expand Down
11 changes: 9 additions & 2 deletions workflows/multiomics/rna_singlesample/main.nf
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,18 @@ workflow run_wf {
// cell filtering
| getWorkflowArguments(key: "filter_with_counts")
| filter_with_counts.run(
args: [ var_gene_names: "gene_symbol" ]
args: [
var_gene_names: "gene_symbol",
obs_name_filter: "filter_with_counts",
var_name_filter: "filter_with_counts"
]
)
| getWorkflowArguments(key: "do_filter")
| do_filter.run(
args: [ obs_filter: "filter_with_counts" ]
args: [
obs_filter: "filter_with_counts",
var_filter: "filter_with_counts"
]
)
// doublet calling
| getWorkflowArguments(key: "filter_with_scrublet")
Expand Down

0 comments on commit 9192dbe

Please sign in to comment.