tools: fix mixup with bytes.decode() and str.encode()

We want to read a bytes file and decode the contents as utf-8 so we can compare against a utf-8 pattern. PR-URL: nodejs#29208 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Mikhus · Aug 22, 2019 · 6afd1a3 · 6afd1a3
1 parent f0c8898
commit 6afd1a3
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/tools/v8_gypfiles/GN-scraper.py b/tools/v8_gypfiles/GN-scraper.py
@@ -7,8 +7,8 @@
 def DoMain(args):
   gn_filename, pattern = args
   src_root = os.path.dirname(gn_filename)
-  with open(gn_filename, 'r') as gn_file:
-    gn_content = gn_file.read().encode('utf-8')
+  with open(gn_filename, 'rb') as gn_file:
+    gn_content = gn_file.read().decode('utf-8')
 
   scraper_re = re.compile(pattern + r'\[([^\]]+)', re.DOTALL)
   matches = scraper_re.search(gn_content)