Skip to content

Commit

Permalink
Documentation/upgrades: revert KeepAlive interface change
Browse files Browse the repository at this point in the history
Signed-off-by: Gyu-Ho Lee <[email protected]>
  • Loading branch information
gyuho committed May 2, 2017
1 parent fdf445b commit bb42ba5
Showing 1 changed file with 0 additions and 26 deletions.
26 changes: 0 additions & 26 deletions Documentation/upgrades/upgrade_3_2.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,32 +30,6 @@ resp.TTL == -1
err == nil
```

Previously, `clientv3.Lease.KeepAlive` interface does not return error (see [#7488](https://github.com/coreos/etcd/issues/7488) and [#7732](https://github.com/coreos/etcd/pull/7732)).

Before

```go
// clientv3
type Lease interface {
KeepAlive(ctx context.Context, id LeaseID) (<-chan *LeaseKeepAliveResponse, error)
KeepAliveOnce(ctx context.Context, id LeaseID) (*LeaseKeepAliveResponse, error)
}
```

After

```go
// clientv3
type Lease interface {
KeepAlive(ctx context.Context, id LeaseID) LeaseKeepAliveChan
KeepAliveOnce(ctx context.Context, id LeaseID) LeaseKeepAliveResponse
}

// check error
for ka := range <-LeaseKeepAliveChan { ka.Err }
LeaseKeepAliveResponse.Err
```

### Server upgrade checklists

#### Upgrade requirements
Expand Down

0 comments on commit bb42ba5

Please sign in to comment.