chore: deny unused crate dependencies (polkadot-evm#1020)

* chore: deny unused crate dependencies

* fix

* apply review suggtions

* fix error

client/cli/src/lib.rs

@@ -16,6 +16,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program. If not, see <https://www.gnu.org/licenses/>.
 
+#![deny(unused_crate_dependencies)]
+
 mod frontier_db_cmd;
 
 pub use self::frontier_db_cmd::FrontierDbCmd;

client/consensus/src/lib.rs

@@ -16,6 +16,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program. If not, see <https://www.gnu.org/licenses/>.
 
+#![deny(unused_crate_dependencies)]
+
 use std::{collections::HashMap, marker::PhantomData, sync::Arc};
 
 // Substrate

client/db/src/lib.rs

@@ -16,6 +16,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program. If not, see <https://www.gnu.org/licenses/>.
 
+#![deny(unused_crate_dependencies)]
+
 #[cfg(feature = "parity-db")]
 mod parity_db_adapter;
 mod upgrade;

client/mapping-sync/src/lib.rs

@@ -17,6 +17,7 @@
 // along with this program. If not, see <https://www.gnu.org/licenses/>.
 
 #![allow(clippy::too_many_arguments)]
+#![deny(unused_crate_dependencies)]
 
 mod worker;
 

client/rpc-core/src/lib.rs

@@ -16,6 +16,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program. If not, see <https://www.gnu.org/licenses/>.
 
+#![deny(unused_crate_dependencies)]
+
 pub mod types;
 
 mod eth;

client/rpc/src/lib.rs

@@ -24,6 +24,7 @@
 	clippy::len_zero,
 	clippy::new_without_default
 )]
+#![deny(unused_crate_dependencies)]
 
 mod eth;
 mod eth_pubsub;

client/storage/src/lib.rs

@@ -16,6 +16,8 @@
 // You should have received a copy of the GNU General Public License
 // along with this program. If not, see <https://www.gnu.org/licenses/>.
 
+#![deny(unused_crate_dependencies)]
+
 mod overrides;
 pub use self::overrides::*;
 

frame/base-fee/Cargo.toml

@@ -23,7 +23,7 @@ fp-evm = { workspace = true }
 
 [dev-dependencies]
 # Substrate
-sp-io = { workspace = true }
+sp-io = { workspace = true, features = ["default"] }
 
 [features]
 default = ["std"]

frame/base-fee/src/lib.rs

@@ -17,6 +17,7 @@
 
 #![cfg_attr(not(feature = "std"), no_std)]
 #![allow(clippy::comparison_chain)]
+#![deny(unused_crate_dependencies)]
 
 #[cfg(test)]
 mod tests;

frame/dynamic-fee/Cargo.toml

@@ -18,16 +18,16 @@ frame-support = { workspace = true }
 frame-system = { workspace = true }
 sp-core = { workspace = true }
 sp-inherents = { workspace = true }
-sp-runtime = { workspace = true }
 sp-std = { workspace = true }
 # Frontier
 fp-dynamic-fee = { workspace = true }
 fp-evm = { workspace = true }
 
 [dev-dependencies]
 # Substrate
-pallet-timestamp = { workspace = true }
-sp-io = { workspace = true }
+pallet-timestamp = { workspace = true, features = ["default"] }
+sp-io = { workspace = true, features = ["default"] }
+sp-runtime = { workspace = true, features = ["default"] }
 
 [features]
 default = ["std"]
@@ -37,7 +37,6 @@ std = [
 	# Substrate
 	"sp-core/std",
 	"sp-inherents/std",
-	"sp-runtime/std",
 	"sp-std/std",
 	# Substrate
 	"frame-system/std",

frame/dynamic-fee/src/lib.rs

@@ -17,6 +17,7 @@
 
 // Ensure we're `no_std` when compiling for Wasm.
 #![cfg_attr(not(feature = "std"), no_std)]
+#![deny(unused_crate_dependencies)]
 
 #[cfg(test)]
 mod tests;

frame/ethereum/Cargo.toml

@@ -14,7 +14,6 @@ targets = ["x86_64-unknown-linux-gnu"]
 ethereum = { workspace = true, features = ["with-codec"] }
 ethereum-types = { workspace = true }
 evm = { workspace = true, features = ["with-codec"] }
-rlp = { workspace = true }
 scale-codec = { package = "parity-scale-codec", workspace = true }
 scale-info = { workspace = true }
 
@@ -31,16 +30,18 @@ fp-consensus = { workspace = true }
 fp-ethereum = { workspace = true }
 fp-evm = { workspace = true }
 fp-rpc = { workspace = true }
-fp-self-contained = { workspace = true }
 fp-storage = { workspace = true }
 pallet-evm = { workspace = true }
 
 [dev-dependencies]
 hex = "0.4.3"
 libsecp256k1 = { workspace = true, features = ["static-context", "hmac"] }
+rlp = { workspace = true }
 # Substrate
 pallet-balances = { workspace = true, features = ["default"] }
-sp-core = { workspace = true }
+sp-core = { workspace = true, features = ["default"] }
+# Frontier
+fp-self-contained = { workspace = true, features = ["default"] }
 
 [features]
 default = ["std"]

frame/ethereum/src/lib.rs

@@ -23,6 +23,7 @@
 // Ensure we're `no_std` when compiling for Wasm.
 #![cfg_attr(not(feature = "std"), no_std)]
 #![allow(clippy::comparison_chain, clippy::large_enum_variant)]
+#![deny(unused_crate_dependencies)]
 
 #[cfg(all(feature = "std", test))]
 mod mock;
@@ -64,7 +65,8 @@ pub use ethereum::{
 };
 pub use fp_rpc::TransactionStatus;
 
-#[derive(Clone, Eq, PartialEq, RuntimeDebug, Encode, Decode, MaxEncodedLen, TypeInfo)]
+#[derive(Clone, Eq, PartialEq, RuntimeDebug)]
+#[derive(Encode, Decode, MaxEncodedLen, TypeInfo)]
 pub enum RawOrigin {
 	EthereumTransaction(H160),
 }

frame/evm-chain-id/src/lib.rs

@@ -26,6 +26,7 @@
 
 // Ensure we're `no_std` when compiling for Wasm.
 #![cfg_attr(not(feature = "std"), no_std)]
+#![deny(unused_crate_dependencies)]
 
 pub use pallet::*;
 

frame/evm/Cargo.toml

@@ -35,7 +35,7 @@ fp-evm = { workspace = true }
 [dev-dependencies]
 # Substrate
 pallet-balances = { workspace = true, features = ["default"] }
-pallet-evm-precompile-simple = { workspace = true }
+pallet-evm-precompile-simple = { workspace = true, features = ["default"] }
 
 [features]
 default = ["std"]

frame/evm/precompile/blake2/src/lib.rs

@@ -16,6 +16,7 @@
 // limitations under the License.
 
 #![cfg_attr(not(feature = "std"), no_std)]
+#![deny(unused_crate_dependencies)]
 
 extern crate alloc;
 

frame/evm/precompile/bn128/src/lib.rs

@@ -16,6 +16,7 @@
 // limitations under the License.
 
 #![cfg_attr(not(feature = "std"), no_std)]
+#![deny(unused_crate_dependencies)]
 
 extern crate alloc;
 

frame/evm/precompile/curve25519/src/lib.rs

@@ -16,6 +16,7 @@
 // limitations under the License.
 
 #![cfg_attr(not(feature = "std"), no_std)]
+#![deny(unused_crate_dependencies)]
 
 extern crate alloc;
 use alloc::vec::Vec;

frame/evm/precompile/dispatch/Cargo.toml

@@ -18,14 +18,14 @@ pallet-evm = { workspace = true }
 scale-codec = { package = "parity-scale-codec", workspace = true }
 scale-info = { workspace = true }
 # Substrate
-frame-system = { workspace = true }
+frame-system = { workspace = true, features = ["default"] }
 pallet-balances = { workspace = true, features = ["default"] }
-pallet-timestamp = { workspace = true }
-pallet-utility = { workspace = true }
-sp-core = { workspace = true }
-sp-io = { workspace = true }
-sp-runtime = { workspace = true }
-sp-std = { workspace = true }
+pallet-timestamp = { workspace = true, features = ["default"] }
+pallet-utility = { workspace = true, features = ["default"] }
+sp-core = { workspace = true, features = ["default"] }
+sp-io = { workspace = true, features = ["default"] }
+sp-runtime = { workspace = true, features = ["default"] }
+sp-std = { workspace = true, features = ["default"] }
 
 [features]
 default = ["std"]

frame/evm/precompile/dispatch/src/lib.rs

@@ -16,6 +16,7 @@
 // limitations under the License.
 
 #![cfg_attr(not(feature = "std"), no_std)]
+#![deny(unused_crate_dependencies)]
 
 extern crate alloc;
 

frame/evm/precompile/ed25519/src/lib.rs

@@ -16,6 +16,7 @@
 // limitations under the License.
 
 #![cfg_attr(not(feature = "std"), no_std)]
+#![deny(unused_crate_dependencies)]
 
 extern crate alloc;
 

frame/evm/precompile/modexp/src/lib.rs

@@ -17,6 +17,7 @@
 
 #![cfg_attr(not(feature = "std"), no_std)]
 #![allow(clippy::comparison_chain)]
+#![deny(unused_crate_dependencies)]
 
 extern crate alloc;
 

frame/evm/precompile/sha3fips/src/lib.rs

@@ -16,6 +16,7 @@
 // limitations under the License.
 
 #![cfg_attr(not(feature = "std"), no_std)]
+#![deny(unused_crate_dependencies)]
 
 extern crate alloc;
 

frame/evm/precompile/simple/src/lib.rs

@@ -16,6 +16,7 @@
 // limitations under the License.
 
 #![cfg_attr(not(feature = "std"), no_std)]
+#![deny(unused_crate_dependencies)]
 
 extern crate alloc;
 

frame/evm/src/lib.rs

@@ -52,8 +52,9 @@
 
 // Ensure we're `no_std` when compiling for Wasm.
 #![cfg_attr(not(feature = "std"), no_std)]
-#![allow(clippy::too_many_arguments)]
 #![cfg_attr(test, feature(assert_matches))]
+#![cfg_attr(feature = "runtime-benchmarks", deny(unused_crate_dependencies))]
+#![allow(clippy::too_many_arguments)]
 
 #[cfg(feature = "runtime-benchmarks")]
 pub mod benchmarking;

frame/evm/test-vector-support/Cargo.toml

@@ -13,6 +13,6 @@ hex = "0.4.3"
 serde = { workspace = true }
 serde_json = { workspace = true }
 # Substrate
-sp-core = { workspace = true }
+sp-core = { workspace = true, features = ["default"] }
 # Frontier
 fp-evm = { workspace = true, features = ["default"] }

frame/evm/test-vector-support/src/lib.rs

@@ -15,6 +15,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+#![deny(unused_crate_dependencies)]
+
 use std::fs;
 
 use evm::{Context, ExitError, ExitReason, ExitSucceed, Transfer};

frame/hotfix-sufficients/Cargo.toml

@@ -26,7 +26,7 @@ pallet-evm = { workspace = true }
 
 [dev-dependencies]
 # Substrate
-sp-io = { workspace = true }
+sp-io = { workspace = true, features = ["default"] }
 
 [features]
 default = ["std"]

frame/hotfix-sufficients/src/lib.rs

@@ -16,6 +16,7 @@
 // limitations under the License.
 
 #![cfg_attr(not(feature = "std"), no_std)]
+#![cfg_attr(feature = "runtime-benchmarks", deny(unused_crate_dependencies))]
 
 #[cfg(feature = "runtime-benchmarks")]
 pub mod benchmarking;

primitives/consensus/src/lib.rs

@@ -17,6 +17,7 @@
 
 #![cfg_attr(not(feature = "std"), no_std)]
 #![allow(clippy::large_enum_variant)]
+#![deny(unused_crate_dependencies)]
 
 use scale_codec::{Decode, Encode};
 use sp_core::H256;

primitives/dynamic-fee/Cargo.toml

@@ -11,14 +11,15 @@ repository = { workspace = true }
 targets = ["x86_64-unknown-linux-gnu"]
 
 [dependencies]
-async-trait = "0.1"
+async-trait = { version = "0.1", optional = true }
 # Substrate
 sp-core = { workspace = true }
 sp-inherents = { workspace = true }
 
 [features]
 default = ["std"]
 std = [
+	"async-trait",
 	# Substrate
 	"sp-core/std",
 	"sp-inherents/std",

primitives/dynamic-fee/src/lib.rs

@@ -18,6 +18,7 @@
 //! Core types and inherents for dynamic fee.
 
 #![cfg_attr(not(feature = "std"), no_std)]
+#![deny(unused_crate_dependencies)]
 
 use sp_core::U256;
 use sp_inherents::InherentIdentifier;

primitives/ethereum/src/lib.rs

@@ -16,6 +16,7 @@
 // limitations under the License.
 
 #![cfg_attr(not(feature = "std"), no_std)]
+#![deny(unused_crate_dependencies)]
 
 pub use ethereum::{
 	AccessListItem, BlockV2 as Block, LegacyTransactionMessage, Log, ReceiptV3 as Receipt,

primitives/evm/src/lib.rs

@@ -16,6 +16,7 @@
 // limitations under the License.
 
 #![cfg_attr(not(feature = "std"), no_std)]
+#![deny(unused_crate_dependencies)]
 
 mod precompile;
 mod validation;

primitives/rpc/src/lib.rs

@@ -17,6 +17,7 @@
 
 #![cfg_attr(not(feature = "std"), no_std)]
 #![allow(clippy::too_many_arguments)]
+#![deny(unused_crate_dependencies)]
 
 use ethereum::Log;
 use ethereum_types::Bloom;

primitives/self-contained/src/lib.rs

@@ -16,6 +16,7 @@
 // limitations under the License.
 
 #![cfg_attr(not(feature = "std"), no_std)]
+#![deny(unused_crate_dependencies)]
 
 mod checked_extrinsic;
 mod unchecked_extrinsic;

primitives/storage/src/lib.rs

@@ -16,6 +16,7 @@
 // limitations under the License.
 
 #![cfg_attr(not(feature = "std"), no_std)]
+#![deny(unused_crate_dependencies)]
 
 use scale_codec::{Decode, Encode};
 

rustfmt.toml

@@ -1,3 +1,4 @@
 hard_tabs = true
 imports_granularity = "Crate"
 use_field_init_shorthand = true
+merge_derives = false