Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

516 Character Preference Screen Weirdness #5846

Open
MonkestationIssueBot opened this issue Mar 7, 2025 · 3 comments
Open

516 Character Preference Screen Weirdness #5846

MonkestationIssueBot opened this issue Mar 7, 2025 · 3 comments
Labels
bug Something isn't working Code: TGUI Involves TGUI in some way, shape or form

Comments

@MonkestationIssueBot
Copy link

Reporting client info: Client Information:
BYOND:516.1658
Key:fmgiv

Round ID:

9815

Testmerges:

Reproduction:

See screenshots, but mainly formatting seems busted on some things (and character preview is tiny)
@FMGIV
Copy link

FMGIV commented Mar 7, 2025

Image

@FMGIV
Copy link

FMGIV commented Mar 7, 2025

Image unless I'm misremembring I'm fairly certain the loadout screen here was supposed to auto-format (or strech to fit)

@flleeppyy
Copy link
Member

Yeah character previews are fucked atm, but the names window thing I can probably fix

@flleeppyy flleeppyy added bug Something isn't working Code: TGUI Involves TGUI in some way, shape or form labels Mar 9, 2025
@Absolucy Absolucy mentioned this issue Mar 11, 2025
Merged
Absolucy added a commit that referenced this issue Mar 11, 2025
@Absolucy @StrangeWeirdKitten
[PORT] HACK: Fixes 516 small character creator bug by shaking screen_…
59142d5 
…loc (#5900)

## About The Pull Request

Fixes the character preview part of
#5846

> So basically there's some byond bug that has made character previews
small and things like cameras offset for the longest time when you open
them.
> 
> Basically when ``/atom/movable/screen/proc/set_position`` is called
and it has an ``assigned_map``, sleep, add three to the x and y offset,
sleep, then reset it. Sorry @\Mothblocks but your original code to
update the character after a second doesn't seem to work anymore.
> 
>
![dreamseeker_a1EDRWfgDA](https://github.com/user-attachments/assets/b7940fa9-ef92-40cd-a700-b22aefdfa286)

## Why It's Good For The Game

> This is not good for the game

## Changelog

:cl: Absolucy, StrangeWeirdKitten
fix: Character creator preview being miniature
/:cl:

---------

Co-authored-by: The Sharkening <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Code: TGUI Involves TGUI in some way, shape or form
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@flleeppyy @FMGIV @MonkestationIssueBot