Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT] HACK: Fixes 516 small character creator bug by shaking screen_loc #5900

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

Absolucy
Copy link
Member

@Absolucy Absolucy commented Mar 11, 2025

About The Pull Request

Fixes the character preview part of #5846

So basically there's some byond bug that has made character previews small and things like cameras offset for the longest time when you open them.

Basically when /atom/movable/screen/proc/set_position is called and it has an assigned_map, sleep, add three to the x and y offset, sleep, then reset it. Sorry @\Mothblocks but your original code to update the character after a second doesn't seem to work anymore.

dreamseeker_a1EDRWfgDA

Why It's Good For The Game

This is not good for the game

Changelog

🆑 Absolucy, StrangeWeirdKitten
fix: Character creator preview being miniature
/:cl:

StrangeWeirdKitten and others added 2 commits March 11, 2025 00:11
…89933)

## About The Pull Request

So basically there's some byond bug that has made character previews
small and things like cameras offset for the longest time when you open
them.

Basically when ``/atom/movable/screen/proc/set_position`` is called and
it has an ``assigned_map``, sleep, add three to the x and y offset,
sleep, then reset it. Sorry @Mothblocks but your original code to update
the character after a second doesn't seem to work anymore.


![dreamseeker_a1EDRWfgDA](https://github.com/user-attachments/assets/b7940fa9-ef92-40cd-a700-b22aefdfa286)



## Why It's Good For The Game

This is not good for the game

## Changelog


:cl:
fix: Character creator preview being miniature
/:cl:
@Absolucy Absolucy added what Code: Fix fix da bug labels Mar 11, 2025
@LikeLakers2 LikeLakers2 added the Code: TGUI Involves TGUI in some way, shape or form label Mar 11, 2025
@Absolucy Absolucy merged commit 59142d5 into Monkestation:master Mar 11, 2025
28 checks passed
@Absolucy Absolucy deleted the virtual-byondsanity branch March 11, 2025 20:01
github-actions bot added a commit that referenced this pull request Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code: Fix fix da bug Code: TGUI Involves TGUI in some way, shape or form what
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants