add error check. (#972)

Signed-off-by: Bo-Yi Wu <[email protected]>
MrJStyle · Jul 4, 2017 · 0f69e1e · 0f69e1e
1 parent a625d91
commit 0f69e1e
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 6 deletions.
diff --git a/upload-file/multiple/main.go b/upload-file/multiple/main.go
@@ -17,16 +17,28 @@ func main() {
  email := c.PostForm("email")
 
  // Multipart form
- form, _ := c.MultipartForm()
+ form, err := c.MultipartForm()
+ if err != nil {
+ c.String(http.StatusBadRequest, fmt.Sprintf("get form err: %s", err.Error()))
+ return
+ }
  files := form.File["files"]
 
  for _, file := range files {
  // Source
- src, _ := file.Open()
+ src, err := file.Open()
+ if err != nil {
+ c.String(http.StatusBadRequest, fmt.Sprintf("file open err: %s", err.Error()))
+ return
+ }
  defer src.Close()
 
  // Destination
- dst, _ := os.Create(file.Filename)
+ dst, err := os.Create(file.Filename)
+ if err != nil {
+ c.String(http.StatusBadRequest, fmt.Sprintf("Create file err: %s", err.Error()))
+ return
+ }
  defer dst.Close()
 
  // Copy

diff --git a/upload-file/single/main.go b/upload-file/single/main.go
@@ -17,12 +17,24 @@ func main() {
  email := c.PostForm("email")
 
  // Source
- file, _ := c.FormFile("file")
- src, _ := file.Open()
+ file, err := c.FormFile("file")
+ if err != nil {
+ c.String(http.StatusBadRequest, fmt.Sprintf("get form err: %s", err.Error()))
+ return
+ }
+ src, err := file.Open()
+ if err != nil {
+ c.String(http.StatusBadRequest, fmt.Sprintf("file open err: %s", err.Error()))
+ return
+ }
  defer src.Close()
 
  // Destination
- dst, _ := os.Create(file.Filename)
+ dst, err := os.Create(file.Filename)
+ if err != nil {
+ c.String(http.StatusBadRequest, fmt.Sprintf("Create file err: %s", err.Error()))
+ return
+ }
  defer dst.Close()
 
  // Copy