fixed disabled menu button hover issue

Mrpanquecas · May 21, 2019 · d50fd07 · d50fd07
1 parent 8905738
commit d50fd07
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/components/Button/Button.js b/src/components/Button/Button.js
@@ -38,22 +38,22 @@ const StyledButton = styled.button`
           ${createBoxStyles()};
           border: 2px solid transparent;
           &:hover {
-            ${createWellBorderStyles(false)}
+            ${({ isDisabled }) => !isDisabled && createWellBorderStyles(false)}
           }
           &:active {
-            ${createWellBorderStyles(true)}
+            ${({ isDisabled }) => !isDisabled && createWellBorderStyles(true)}
           }
           ${({ active }) => active && createBorderStyles(true)}
+          ${({ isDisabled }) => isDisabled && createDisabledTextStyles()}
         `
       : css`
           ${createBoxStyles()};
           ${({ active }) =>
             active ? createBorderStyles(true) : createBorderStyles(false)}
-          ${({ isDisabled }) =>
-            isDisabled && createDisabledTextStyles()}
-        &:active {
+          &:active {
             ${({ isDisabled }) => !isDisabled && createBorderStyles(true)}
           }
+          ${({ isDisabled }) => isDisabled && createDisabledTextStyles()}
         `}
   ${commonButtonStyles}
 `;

diff --git a/src/components/Window/Window.stories.js b/src/components/Window/Window.stories.js
@@ -28,7 +28,7 @@ storiesOf("Window", module)
         <Button variant="menu" size="sm">
           Edit
         </Button>
-        <Button variant="menu" size="sm">
+        <Button variant="menu" size="sm" disabled>
           Save
         </Button>
       </Toolbar>