Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[QoS] Tweak SetCurrentThreadQualityOfService on Windows
In this change, SetCurrentThreadQualityOfService: - No longer uses GetProcAddress to find SetThreadInformation, as this function was added in Windows 8. This removes unneeded contention on the loader lock along with the associated complexity. - No longer checks the OS version before use; instead, we trust that versions of Windows prior to Windows 10, version 1709 will ignore a call to SetThreadInformation with an unsupported THREAD_INFORMATION_CLASS. The motivation for this is that the OS check was implicated in renderer startup hangs, as it requires resolving a delayload to reach the Windows registry. The OS version check is now only done to suppress the debug log message in case of failure, as failure is expected on versions of Windows prior to 1709. Bug: 1278628, 1482568 Change-Id: Ib73251a316c245aad75cc19cc785d9a5398d50c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4976221 Reviewed-by: Gabriel Charette <[email protected]> Reviewed-by: Will Harris <[email protected]> Commit-Queue: Will Harris <[email protected]> Auto-Submit: Greg Thompson <[email protected]> Cr-Commit-Position: refs/heads/main@{#1215530}
- Loading branch information