[framework-snaps] Update snapshot loading #21193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since deployed protocol versions are not guaranteed to be sequential, snapshots are not guaranteed to be sequential (e.g., 45 may exist, 46 may not, but 47 may). Previously when trying to load a snapshot for a protocol version we would only load a snapshot if there was one for that exact version, otherwise we'd default to the newest version of the framework. This is incorrect, and @Dario has run into problems with this. This updates snapshot loading so if a snapshot for a particular version `v` is not found, the least version greater than the given version is returned.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
dariorussi
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
assuming all tests pass, this is fine by me as we extensively talked about offline.
Would be great if @bmwill could take a look as well
bmwill
approved these changes
Feb 13, 2025
Co-authored-by: ronny-mysten <[email protected]>
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
|
cc @mdgeorge4153 (no action, but changes in an area you're working in, related to our earlier discussion about gaps in the snapshot manifest) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since deployed protocol versions are not guaranteed to be sequential, snapshots are not guaranteed to be sequential (e.g., 45 may exist, 46 may not, but 47 may).
Previously when trying to load a snapshot for a protocol version we would only load a snapshot if there was one for that exact version, otherwise we'd default to the newest version of the framework. This is incorrect, and @dariorussi has run into problems with this.
This updates snapshot loading so if a snapshot for a particular version
vis not found, the least version greater than the given version is returned.Test plan
CI
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.