Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for http(s) proxies #92

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adding support for http(s) proxies #92

wants to merge 2 commits into from

Conversation

tylern4
Copy link
Member

@tylern4 tylern4 commented Oct 16, 2024

Add support for http(s) proxies based on standard proxy environment variables including socks5 proxy. This could help for interacting with the SFAPI from other HPC systems which use http(s) proxies for connecting from compute nodes to the outside world (ALCF and OLCF often have a proxy to be able to connect to compute nodes).

@tylern4 tylern4 requested a review from cjh1 October 16, 2024 04:16
@cjh1
Copy link
Collaborator

cjh1 commented Oct 16, 2024

How does this differ from just setting HTTP_PROXY or HTTPS_PROXY and installing pip install httpx[sock], which seems to work without code changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants