Fix a compiler NotImplementedException (dotnet#2331)

* Fix a compiler warning * Prevent NotImplementedException in some test cases * No need for two builds on a push to a PR
NOUIY · Jul 18, 2024 · 84c7f37 · 84c7f37
1 parent 306bd2e
commit 84c7f37
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/.github/workflows/arduino.yml b/.github/workflows/arduino.yml
@@ -4,9 +4,6 @@ name: Arduino_Compiler_CI
 
 # Controls when the workflow will run
 on:
-  # Triggers the workflow on push or pull request events
-  push:
-
   # Allows you to run this workflow manually from the Actions tab
   workflow_dispatch:
   pull_request:

diff --git a/src/System.Device.Gpio/System/Device/Gpio/Drivers/Libgpiod/LibGpiodDriver.cs b/src/System.Device.Gpio/System/Device/Gpio/Drivers/Libgpiod/LibGpiodDriver.cs
@@ -145,8 +145,10 @@ protected internal override void Write(int pinNumber, PinValue value)
     public override ComponentInformation QueryComponentInformation()
     {
         var ret = new ComponentInformation(this, "Libgpiod Wrapper driver");
+#pragma warning disable SDGPIO0001
         ret.Properties.Add("Version", Version.ToString());
         ret.AddSubComponent(GetDriver().QueryComponentInformation());
+#pragma warning restore SDGPIO0001
         return ret;
     }
 

diff --git a/tools/ArduinoCsCompiler/Runtime/MiniInterop.Kernel32.cs b/tools/ArduinoCsCompiler/Runtime/MiniInterop.Kernel32.cs
@@ -152,7 +152,7 @@ internal static unsafe int CompareStringOrdinal(
             internal static unsafe int LCMapStringEx(string lpLocaleName, uint dwMapFlags, char* lpSrcStr, int cchsrc, void* lpDestStr,
                 int cchDest, void* lpVersionInformation, void* lpReserved, IntPtr sortHandle)
             {
-                throw new NotImplementedException();
+                return 0; // Can apparently be null in InvariantCulture mode.
             }
 
             internal static int FindNLSString(