Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel Weather Downloads (NSRDB, PVGIS) #143

Open
wants to merge 15 commits into
base: development
Choose a base branch
from

Conversation

tobin-ford
Copy link
Collaborator

Describe your changes

Utilities for parallelized downloading of PVGIS and NSRDB. This is useful because it allows us to max out the 30 requests/sec to PVGIS using dask for multiprocessing. Not as useful for NSRDB because of the low rate limit per day on api requests.

This is being pushed forward in anticipation of GeoGridFusion being released publicly.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • Code changes are covered by tests.
  • Code changes have been evaluated for compatibility/integration with Scenario analysis (for future PRs)
  • Code changes have been evaluated for compatibility/integration with geospatial autotemplating (for future PRs)
  • New functions added to init.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • What's new changelog has been updated in the docs

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 63.07692% with 48 lines in your changes missing coverage. Please review.

Project coverage is 65.52%. Comparing base (f7469ec) to head (643c586).

Files with missing lines Patch % Lines
pvdeg/store.py 33.33% 26 Missing ⚠️
pvdeg/weather.py 66.66% 21 Missing ⚠️
pvdeg/scenario.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #143      +/-   ##
===============================================
+ Coverage        65.42%   65.52%   +0.09%     
===============================================
  Files               36       37       +1     
  Lines             3575     3704     +129     
===============================================
+ Hits              2339     2427      +88     
- Misses            1236     1277      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants