Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Trofos API endpoints from endpoints.ts to environment file #238

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

dexter-sim
Copy link
Contributor

Description

Migrate endpoints to environment as local and SOC VM requires different API endpoints.

Changes

Local environment file:
TROFOS_URI="https://trofos-production.comp.nus.edu.sg/api/external/v1"

VM environment file:
TROFOS_URI="https://trofos-production-i.comp.nus.edu.sg/api/external/v1"

Additional Notes

Resolves #237

@dexter-sim dexter-sim added type: bug Something isn't working priority: high labels Oct 17, 2024
@dexter-sim dexter-sim self-assigned this Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.14%. Comparing base (9cc6b22) to head (a08d143).
Report is 2 commits behind head on staging.

Additional details and impacted files
@@           Coverage Diff            @@
##           staging     #238   +/-   ##
========================================
  Coverage    91.14%   91.14%           
========================================
  Files           27       27           
  Lines         1411     1411           
  Branches       244      244           
========================================
  Hits          1286     1286           
  Misses         110      110           
  Partials        15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@Nephelite Nephelite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also you ended up changing the route strings in the end, lol

@dexter-sim dexter-sim merged commit dc741af into staging Oct 17, 2024
4 checks passed
@dexter-sim dexter-sim mentioned this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants