Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily skip the DeepSeek test #4126

Merged
merged 1 commit into from
Mar 21, 2025
Merged

Temporarily skip the DeepSeek test #4126

merged 1 commit into from
Mar 21, 2025

Conversation

wujingyue
Copy link
Collaborator

No description provided.

@wujingyue
Copy link
Collaborator Author

!test

@wujingyue wujingyue requested a review from naoyam March 21, 2025 15:31
@wujingyue wujingyue added the bug Something isn't working label Mar 21, 2025
Copy link

Description

  • Temporarily skip DeepSeek test due to flakiness

Changes walkthrough 📝

Relevant files
Tests
test_deepseek_v3.py
Skip DeepSeek test due to flakiness                                           

tests/python/test_deepseek_v3.py

  • Import pytest module
  • Add @pytest.mark.skip decorator to test_transformer_layer
  • +2/-0     

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🧪 No relevant tests
    ⚡ Recommended focus areas for review

    Test Skipped

    The test test_transformer_layer is being skipped due to a download timeout issue. It's important to understand the root cause of the timeout and consider alternative solutions to ensure the test can run reliably.

    @pytest.mark.skip(reason="flaky on CI due to download timeout: http://nv/eCm")

    @wujingyue wujingyue merged commit cd19a7b into main Mar 21, 2025
    53 checks passed
    @wujingyue wujingyue deleted the wjy/skip branch March 21, 2025 19:09
    @wujingyue
    Copy link
    Collaborator Author

    cc @syed-ahmed in case you know how to download HF models correctly in a unit test. I saw Thunder tests doing that so I think it's a matter of configuration.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    bug Something isn't working
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants