fix invalid link to new deploy

NamPNQ · Mar 10, 2015 · 2e48aa7 · 2e48aa7
1 parent ecfcbcf
commit 2e48aa7
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/app/helpers/releases_helper.rb b/app/helpers/releases_helper.rb
@@ -20,10 +20,10 @@ def release_label(project, release)
   end
 
   def link_to_deploy_stage(stage, release)
-    deploy_params = { reference: release.version, stage_id: stage.id }
+    deploy_params = { reference: release.version }
 
     if stage.confirm_before_deploying?
-      link_to stage.name, new_project_deploy_path(@project, deploy_params)
+      link_to stage.name, new_project_stage_deploy_path(@project, stage, deploy_params)
     else
       link_to stage.name, project_deploys_path(@project, deploy: deploy_params), method: :post
     end

diff --git a/test/helpers/releases_helper_test.rb b/test/helpers/releases_helper_test.rb
@@ -0,0 +1,18 @@
+require_relative '../test_helper'
+
+describe ReleasesHelper do
+  describe "#link_to_deploy_stage" do
+    let(:stage) { stages(:test_staging) }
+    let(:release) { Release.new }
+    before { @project = stage.project } # ugly ...
+
+    it "links to a new deploy when it needs to be confirmed" do
+      stage.confirm = true
+      link_to_deploy_stage(stage, release).must_include "/projects/foo/stages/staging/deploys/new?"
+    end
+
+    it "links creating a deploy when it does not needs to be confirmed" do
+      link_to_deploy_stage(stage, release).must_include "/projects/foo/deploys?"
+    end
+  end
+end