Fix non-working Ctrl+c on windows #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
rosen-vladimirov
approved these changes
May 16, 2018
src/lib/compiler.js
Outdated
| if (fs.existsSync(sassPath)) { | ||
| logger.info("Found peer node-sass"); | ||
| } else { | ||
| throw new Error('node-sass installation local to project was not found. Install by executing `npm install node-sass`.'); |
There was a problem hiding this comment.
maybe this should be reject(new Error(...))
There was a problem hiding this comment.
and set isResolved to true
src/lib/log-provider.js
Outdated
| return logger[data.logLevel](data.message); | ||
| } | ||
|
|
||
| process.send(JSON.stringify(data)); |
There was a problem hiding this comment.
you can just send the data, no need to stringify it
src/lib/watcher.js
Outdated
| pollInterval: 100, | ||
| stabilityThreshold: 300 | ||
| }, | ||
| ignored: ['**/.*', '.*', path.join(appDir, "App_Resources")] // hidden files and App_Resources folder |
There was a problem hiding this comment.
maybe we need to use the projectData.appDirectoryPath here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
When CTRL+C is pressed on windows, the application is NOT terminated
What is the new behavior?
When CTRL+C is pressed on windows, the application is terminated
Fixes #76