Skip to content

Commit

Permalink
doc: precision about makefile (dunglas#185)
Browse files Browse the repository at this point in the history
  • Loading branch information
COil authored Oct 28, 2021
1 parent 97ae6ef commit d4c3b50
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion docs/makefile.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,16 @@ you will probably want to add some targets like running your tests as described
in [the Symfony book](https://symfony.com/doc/current/the-fast-track/en/17-tests.html#automating-your-workflow-with-a-makefile).
You can also find a more complete example in this [snippet](https://www.strangebuzz.com/en/snippets/the-perfect-makefile-for-symfony).

If you want to run make from within the `php` container, in the [Dockerfile](/Dockerfile),
add:

```diff
gnu-libiconv \
+make \
```

And rebuild the PHP image.

**PS**: If using Windows, you have to install [chocolatey.org](https://chocolatey.org/)
or use [Cygwin](http://cygwin.com) to use the `make` command. Check out this
[StackOverflow question](https://stackoverflow.com/q/2532234/633864) for more explanations.
Expand Down Expand Up @@ -49,7 +59,7 @@ build: ## Builds the Docker images
up: ## Start the docker hub in detached mode (no logs)
@$(DOCKER_COMP) up --detach

start: build up ## Build and starts the containers
start: build up ## Build and start the containers

down: ## Stop the docker hub
@$(DOCKER_COMP) down --remove-orphans
Expand Down

0 comments on commit d4c3b50

Please sign in to comment.