Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove {version} inside download link in README #13

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

a3626a
Copy link
Contributor

@a3626a a3626a commented Oct 13, 2023

깃 릴리즈 경로와 리드미에서 제시된 예시 경로가 일치하지 않아 변경 제안드립니다.

현재 깃 릴리즈에서 생성되는 파일 경로는
https://github.com/NaverCloudPlatform/ncp-iam-authenticator/releases/download/v1.1.1/ncp-iam-authenticator_linux_amd64 입니다.

그러나 변경 전 리드미에서는 이를
ncp-iam-authenticator_${version}_${os}_${arch} 로 표현하고 있으므로 일치하지 않습니다.

제가 제안드린대로 변경되면 정상적으로 설치됨을 확인했습니다.

Copy link
Collaborator

@gimmetm gimmetm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제안주셔서 감사합니다.

@gimmetm gimmetm merged commit ca5c10c into NaverCloudPlatform:main Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants