Enable docker, #18 #19

Awkan · 2017-09-06T10:15:23Z

No description provided.

Nek- · 2017-09-06T14:17:04Z

.env.dist

@@ -0,0 +1,2 @@
+HTTPD_PORT=80
+PMA_PORT=8090


Missing new line at EOF

Nek- · 2017-09-06T14:18:18Z

docker-compose.yml

+        build: docker/php
+        volumes:
+            - .:/var/www/
+            - ./docker/php/php.ini:/usr/local/etc/php/conf.d/custom.ini


you already copy this file in the dockerfile ;)

Nek- · 2017-09-06T14:20:20Z

web/app_dev.php

@@ -19,7 +19,7 @@
    header('HTTP/1.0 403 Forbidden');
    exit('You are not allowed to access this file. Check '.basename(__FILE__).' for more information.');
 }
-//*/
+*/


Protip: this modification is useless. When you remove the first / it automatically comments the whole block and when you add it, it uncomments the block. :)

Nek- · 2017-09-06T14:23:18Z

web/app_dev.php

@@ -10,7 +10,7 @@
 // This check prevents access to debug front controllers that are deployed by accident to production servers.
 // Feel free to remove this, extend it, or make something more sophisticated.

-//*
+/*


I'm 👎 with this change as it may generate a serious security issue if you forget to drop the app_dev.php file. Otherwise adding the environment in the .env file looks like a good idea to me.

You'll need to change the app.php file to support an environment var.

Nek- · 2017-09-06T14:23:38Z

package.json

+        "less": "1.7.*",
+        "bower": "*",
+        "uglify-js": "*",
+        "uglifycss": "*"


Nek- · 2017-09-06T14:26:21Z

docker/php/Dockerfile

+
+COPY php.ini /usr/local/etc/php/conf.d/custom.ini
+
+# End docker config


hu ? actually nope 2 last line are still docker config haha.

Nek- · 2017-09-06T14:27:25Z

docker/nginx/server.conf

+    }
+
+    # DEV
+    location ~ ^/(app_dev|config)\.php(/|$) {


Dropping app_dev.php (as asked in a previous comment) impact this. (this section should probably simply dropped)

Nek- · 2017-09-06T14:31:51Z

app/config/parameters.yml.dist

@@ -1,10 +1,10 @@
 parameters:
    database_driver:   pdo_mysql
-    database_host:     127.0.0.1
+    database_host:     db


Add a comment with "You may want to change to 127.0.0.1 if you don't use docker)

Nek- · 2017-09-06T14:33:48Z

docker/nginx/server.conf

+    }
+
+    error_log /var/log/nginx/neko_wiki.log;
+    access_log /var/log/nginx/neko_wiki.log;


That's great. What is bad is that it's not reported outside of the docker. 2 solutions:

configure (or check if it's not already the case?) to report on stderr (so it can be log by docker-compose logs)

share the log directory with var/logs (and don't forget to add it in the .gitignore)

I'll add it to var/logs folder

Nek- · 2017-09-06T14:35:33Z

docker/php/php.ini

@@ -0,0 +1 @@
+date.timezone= "UTC"


Interesting. That's probably the best configuration. Servers configured in France will probably have Europe/Paris. We need to adapt the code to support many timezone... And this is a critical issue.

Awkan · 2017-09-06T18:27:56Z

@Nek- I fixed your comments + update README.md file in order to add Docker steps

Nek- · 2017-09-06T21:32:23Z

web/app.php

+    // Change 'sf2' to a unique prefix in order to prevent cache key conflicts
+    // with other applications also using APC.
+    /*
+    $apcLoader = new ApcClassLoader('sf2', $loader);


would be great to have NekoWiki here? :)

Nek- · 2017-09-06T21:33:48Z

@Awkan thanks this work is awesome. :) I just need to test it with standard installation (without docker) then it's good to me.

Nek- · 2017-09-07T20:59:37Z

docker/php/Dockerfile

+COPY php.ini /usr/local/etc/php/conf.d/custom.ini
+
+# Set default user + dir
+USER www-data


This looks like an issue. IDK why but when I run the docker-compose (ubuntu/16.04) the docker cannot write in cache folder.

I replaced with this line (found on the web): RUN usermod -u 1000 www-data

That worked for me, can you try if it's ok to you?

Also adding RUN echo 'alias sf="php app/console"' >> ~/.bashrc is a great idea to me, if you can id be glad to use it. 😄

I only use USER www-data to default connect to container with www-data user. Otherwise we just have to specify user : docker-compose exec --user www-data php bash. I'll remove the line since www-datais created by default.

It give:

# cat /etc/passwd | grep www-data www-data:x:33:33:www-data:/var/www:/usr/sbin/nologin

I'll add alias ;-)

I tried also without this clause... I was surprise to see that even without this (which means root?! right??). I still had rights issue. Maybe root is not the 1000 user? It's something weird with docker I don't explain for now.

Btw it's probably fixed on dockermac because they run it inside a VM that have no special rights on.

It may be because of ACL I used on my cache directory (well it's probably because of that). As my user (nek) is 1000 on my computer, forcing www-data to 1000 inside the docker fix the issue ("www-data" use the same id as "nek" on my computer and all is good).

This fix may be an issue if somebody comes out with a user with id 1001 :')... I don't have a better solution for now.

Awkan changed the title ~~Enable docker, #18~~ WIP: Enable docker, #18 Sep 6, 2017

Nek- requested changes Sep 6, 2017

View reviewed changes

Nek- mentioned this pull request Sep 6, 2017

Timezone management #20

Open

Enable docker, Nekland#18

ed582c3

Awkan force-pushed the feature/18-docker branch from e479b67 to 072fe92 Compare September 6, 2017 18:15

Awkan changed the title ~~WIP: Enable docker, #18~~ Enable docker, #18 Sep 6, 2017

Fix docker config, Nekland#18

55c488a

Awkan force-pushed the feature/18-docker branch from 072fe92 to 55c488a Compare September 6, 2017 18:26

Nek- reviewed Sep 6, 2017

View reviewed changes

Fix apc class loader prefix + package name, Nekland#18

f4dedef

Awkan force-pushed the feature/18-docker branch from d20ba04 to f4dedef Compare September 7, 2017 07:02

Nek- requested changes Sep 7, 2017

View reviewed changes

Update www-data user creation + add sf alias, Nekland#18

0b8c35b

Awkan force-pushed the feature/18-docker branch from f412951 to 0b8c35b Compare September 8, 2017 07:10

Nek- approved these changes Sep 8, 2017

View reviewed changes

Nek- merged commit b88d324 into Nekland:master Sep 8, 2017

Awkan deleted the feature/18-docker branch September 8, 2017 08:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable docker, #18 #19

Enable docker, #18 #19

Awkan commented Sep 6, 2017 •

edited

Loading

Nek- Sep 6, 2017

Nek- Sep 6, 2017

Nek- Sep 6, 2017

Nek- Sep 6, 2017

Nek- Sep 6, 2017

Nek- Sep 6, 2017

Nek- Sep 6, 2017

Nek- Sep 6, 2017

Nek- Sep 6, 2017

Nek- Sep 6, 2017

Awkan Sep 6, 2017

Nek- Sep 6, 2017

Awkan commented Sep 6, 2017 •

edited

Loading

Nek- Sep 6, 2017

Nek- commented Sep 6, 2017 •

edited

Loading

Nek- Sep 7, 2017

Awkan Sep 8, 2017

Nek- Sep 8, 2017

Nek- Sep 8, 2017


		COPY php.ini /usr/local/etc/php/conf.d/custom.ini

		# End docker config

		@@ -0,0 +1,2 @@
		HTTPD_PORT=80
		PMA_PORT=8090

Enable docker, #18 #19

Enable docker, #18 #19

Conversation

Awkan commented Sep 6, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Awkan commented Sep 6, 2017 • edited Loading

Choose a reason for hiding this comment

Nek- commented Sep 6, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Awkan commented Sep 6, 2017 •

edited

Loading

Awkan commented Sep 6, 2017 •

edited

Loading

Nek- commented Sep 6, 2017 •

edited

Loading