Support TSP App 2121-1 #263
Conversation
Codecov Report
@@ Coverage Diff @@
## master #263 +/- ##
============================================
- Coverage 67.86% 66.54% -1.32%
Complexity 1609 1609
============================================
Files 158 160 +2
Lines 11226 11457 +231
Branches 1701 1742 +41
============================================
+ Hits 7618 7624 +6
- Misses 2798 3023 +225
Partials 810 810
Continue to review full report at Codecov.
|
|
Hi @cconcolato, Best, |
|
Hi, is there an ETA of this being released? I noticed that photon now supports application 5, but App 2121-1 is still waiting to be merged and released. |
|
@cconcolato do you have a little bit of time ? |
|
@MarcAntoine-Arnaud, will you be extending this to support TSP 2121-4 ? |
…pixel bit depth parsing
…Tsp2121DescriptorModel And a little refactoring
| public enum ApplicationCompositionType { | ||
| APPLICATION_2_COMPOSITION_TYPE(Application2Composition.class, namespacesApplication2Composition), | ||
| APPLICATION_2E_COMPOSITION_TYPE(Application2ExtendedComposition.class, namespacesApplication2EComposition), | ||
| APPLICATION_5_COMPOSITION_TYPE(Application5Composition.class, namespacesApplication5Composition), | ||
| APPLICATION_TSP_2121_COMPOSITION_TYPE(ApplicationTsp2121Composition.class, namespacesApplicationTsp2121Composition), |
There was a problem hiding this comment.
TSP 2121 has many parts. ApplicationTsp2121 could be replaced by ApplicationTsp2121Part1 or ApplicationDPPProRes.
|
Could you add a test file that exercises the code you added? Code coverage is at 0% for ApplicationTsp2121Composition.java. |
update of #234