Use criterion for benchmarking (tikv#30)

Signed-off-by: koushiro <[email protected]>

.github/workflows/rust.yml

@@ -45,11 +45,11 @@ jobs:
  - name: Checkout sources
  uses: actions/checkout@v2
 
- - name: Install Rust nightly toolchain
+ - name: Install Rust toolchain
  uses: actions-rs/toolchain@v1
  with:
  profile: minimal
- toolchain: nightly
+ toolchain: stable
  override: true
 
  - name: Run cargo test

Cargo.toml

@@ -29,6 +29,7 @@ prost = { version = "0.6", optional = true }
 prost-derive = { version = "0.6", optional = true }
 
 [dev-dependencies]
+criterion = "0.3"
 rand = "0.7.2"
 
 [build-dependencies]
@@ -46,5 +47,10 @@ required-features = ["protobuf"]
 name = "multithread_flamegraph"
 required-features = ["flamegraph"]
 
+[[bench]]
+name = "collector"
+path = "benches/collector.rs"
+harness = false
+
 [package.metadata.docs.rs]
 all-features = true

benches/collector.rs

@@ -0,0 +1,43 @@
+// Copyright 2019 TiKV Project Authors. Licensed under Apache-2.0.
+
+use criterion::{criterion_group, criterion_main, Criterion};
+use pprof::{Collector, StackHashCounter};
+
+fn bench_write_to_collector(c: &mut Criterion) {
+ c.bench_function("write_to_collector", |b| {
+ let mut collector = Collector::new().unwrap();
+
+ const SIZE: usize = 1000;
+
+ let mut vec: Vec<u64> = Vec::with_capacity(SIZE);
+ for _ in 0..vec.capacity() {
+ vec.push(rand::random());
+ }
+
+ b.iter(|| {
+ vec.iter().for_each(|item| {
+ collector.add(*item, 1).unwrap();
+ })
+ })
+ });
+
+ c.bench_function("write_into_stack_hash_counter", |b| {
+ let mut collector = StackHashCounter::default();
+
+ const SIZE: usize = 1000;
+
+ let mut vec: Vec<u64> = Vec::with_capacity(SIZE);
+ for _ in 0..vec.capacity() {
+ vec.push(rand::random());
+ }
+
+ b.iter(|| {
+ vec.iter().for_each(|item| {
+ collector.add(*item, 1);
+ })
+ });
+ });
+}
+
+criterion_group!(benches, bench_write_to_collector);
+criterion_main!(benches);

src/collector.rs

@@ -254,7 +254,6 @@ mod tests {
  use std::cell::RefCell;
  use std::collections::BTreeMap;
  use std::ffi::c_void;
- use test::Bencher;
 
  #[test]
  fn stack_hash_counter() {
@@ -409,40 +408,4 @@ mod tests {
  }
  }
  }
-
- #[bench]
- fn write_into_collector(b: &mut Bencher) {
- let mut collector = Collector::new().unwrap();
-
- const SIZE: usize = 1000;
-
- let mut vec: Vec<u64> = Vec::with_capacity(SIZE);
- for _ in 0..vec.capacity() {
- vec.push(rand::random());
- }
-
- b.iter(|| {
- vec.iter().for_each(|item| {
- collector.add(item.clone(), 1).unwrap();
- });
- });
- }
-
- #[bench]
- fn write_into_stack_hash_counter(b: &mut Bencher) {
- let mut collector = StackHashCounter::default();
-
- const SIZE: usize = 1000;
-
- let mut vec: Vec<u64> = Vec::with_capacity(SIZE);
- for _ in 0..vec.capacity() {
- vec.push(rand::random());
- }
-
- b.iter(|| {
- vec.iter().for_each(|item| {
- collector.add(item.clone(), 1);
- });
- });
- }
 }

src/lib.rs

@@ -21,11 +21,6 @@
 //!};
 //! ```
 
-#![cfg_attr(test, feature(test))]
-
-#[cfg(test)]
-extern crate test;
-
 /// Define the MAX supported stack depth. TODO: make this variable mutable.
 pub const MAX_DEPTH: usize = 32;
 
@@ -39,6 +34,7 @@ mod profiler;
 mod report;
 mod timer;
 
+pub use self::collector::{Collector, StackHashCounter};
 pub use self::error::{Error, Result};
 pub use self::frames::{Frames, Symbol};
 pub use self::profiler::ProfilerGuard;