Feature - Swift 3.2 Support #30
Merged
+287
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejensen
reviewed
Aug 29, 2017
| @@ -49,7 +49,7 @@ func ==(lhs: TestObject, rhs: TestObject) -> Bool { | |||
|
|
|||
| // MARK: - | |||
|
|
|||
| extension TestObject: Encodable, Decodable { | |||
| extension TestObject: Elevate.Encodable, Elevate.Decodable { | |||
There was a problem hiding this comment.
Do you think the example code in the README should also have the Elevate namespace prefixed?
There was a problem hiding this comment.
Yep, good catch. Will fix. 👍🏻
ejensen
approved these changes
Aug 29, 2017
cnoon
force-pushed
the
feature/swift-3.2-support
branch
from
1cbda63 to
99fafed
Compare
cnoon
force-pushed
the
feature/swift-3.2-support
branch
from
99fafed to
f6a0f4a
Compare
EricAppel
approved these changes
Aug 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Xcode 9 and Swift 3.2 as well as support for SPM. Once this is merged, we'll cut the
2.2.2release.