Skip to content

Commit

Permalink
cmake: : link shec_utils against legacy-option-headers
Browse files Browse the repository at this point in the history
in c24a6ff, we tried to link all target dependent on legacy option
headers against legacy-option-headers, but we missed some of them.
in our CI, we spotted build failure like:
```
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/erasure-code/ErasureCode.cc:26:
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/osd/osd_types.h:41:
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/common/ceph_context.h:41:
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/common/config_proxy.h:6:
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/common/config.h:27:
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/common/config_values.h:59:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/common/options/legacy_config_opts.h:1:10: fatal error: 'global_legacy_options.h' file not found
         ^~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
```
so in this change, we link the shec_utils to `legacy-option-headers`
as well to fulfill the build dependency.

Signed-off-by: Kefu Chai <[email protected]>
  • Loading branch information
tchaikov committed May 24, 2024
1 parent de7b8ac commit 02bd5e1
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/erasure-code/shec/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ set(shec_utils_srcs
determinant.c)

add_library(shec_utils OBJECT ${shec_utils_srcs})
target_link_libraries(shec_utils
PRIVATE legacy-option-headers)

set(ec_shec_objs
$<TARGET_OBJECTS:gf-complete_objs>
Expand Down

0 comments on commit 02bd5e1

Please sign in to comment.